-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Khan #6
base: master
Are you sure you want to change the base?
Khan #6
Commits on Jun 2, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 4582bb4 - Browse repository at this point
Copy the full SHA 4582bb4View commit details
Commits on Jun 5, 2014
-
Fire MathField:edited handler when swapping between the [< ≤] and [> …
…≥] pairs Test Plan: Confirmed that the `edited` handler is now called on swap (pressing "=" when < or > is left of cursor, or deleting when ≤ or ≥ is left of cursor).
Alex Lopatin committedJun 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 4c0c07b - Browse repository at this point
Copy the full SHA 4c0c07bView commit details -
Fix ReferenceError when using mathquill-basic build
Test Plan: Created a fraction without getting a JS error.
Alex Lopatin committedJun 5, 2014 Configuration menu - View commit details
-
Copy full SHA for a0423f6 - Browse repository at this point
Copy the full SHA a0423f6View commit details -
Add advancedSymbols.js to mathquill-basic build (to include ≠)
Test Plan: Successfully insert ≠ by pasting \ne.
Alex Lopatin committedJun 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 2160b66 - Browse repository at this point
Copy the full SHA 2160b66View commit details -
Change font link from incorrect relative URL to correct absolute URL
Not sure if this is the best way to do this - KaTeX seems to somehow use just the file name and has it resolve correctly. Suggestions appreciated! Test Plan: See fonts render correctly in webapp Auditors: jack
Alex Lopatin committedJun 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 7772a97 - Browse repository at this point
Copy the full SHA 7772a97View commit details -
Track built files in source control + build
Test Plan: Make subrepo, see built files present without having to build.
Alex Lopatin committedJun 5, 2014 Configuration menu - View commit details
-
Copy full SHA for ca60aa2 - Browse repository at this point
Copy the full SHA ca60aa2View commit details
Commits on Jul 23, 2014
-
Don't break out of superscript on negation, regardless of subtraction…
… behavior. Summary: Previously, if you included '-' in `MathQuill.addCharsThatBreakOutOfSupSub()` it would prevent you from being able to enter negative exponents. This is a shame because the behavior is otherwise desirable - at all other times, you want to break out of a super/subscript by default when encountering subtraction that isn't wrapped in parentheses. This fixes the behavior by always allowing a (single) negative sign to be inserted as the first character inside a super/subscript. Addresses some of T2730 Test Plan: In Perseus' MathInput, verified the following: 1) Typing 'x^a-b' results in (x^a) - b 2) Typing 'x^-a-b' results in (x^-a) - b 3) Typing 'x^a', moving left once, then typing '-' results in (x^-a) Reviewers: alpert Reviewed By: alpert Subscribers: michelle, jack Differential Revision: http://phabricator.khanacademy.org/D11366
Alex Lopatin committedJul 23, 2014 Configuration menu - View commit details
-
Copy full SHA for 6f48637 - Browse repository at this point
Copy the full SHA 6f48637View commit details
Commits on Aug 21, 2014
-
Fix second blinking cursor on mathquill editor on iOS
Summary: Fixes the second blinking cursor seen on iOS (mathquill#310). Test Plan: - Test mathquill editor on iOS and observe that there is only one cursor Reviewers: aria, alex Reviewed By: alex Differential Revision: http://phabricator.khanacademy.org/D12105
Configuration menu - View commit details
-
Copy full SHA for 5d7cd2e - Browse repository at this point
Copy the full SHA 5d7cd2eView commit details
Commits on Feb 4, 2015
-
Change zero-width joiner to zero-width space because of wrong
rendering in Chrome v40.xxxxxx Conflicts: src/cursor.js
Configuration menu - View commit details
-
Copy full SHA for 5a568a2 - Browse repository at this point
Copy the full SHA 5a568a2View commit details -
Build (Fix cursor showing up as an ugly box in Chrome 40)
Test Plan: Made the change locally in webapp, observed that the box goes away here: /math/cc-sixth-grade-math/cc-6th-expressions-and-variables/cc-6th-writing-expressions/e/writing-expressions-with-variables-word-problems Auditors: @aria
Alex Lopatin committedFeb 4, 2015 Configuration menu - View commit details
-
Copy full SHA for 20c4364 - Browse repository at this point
Copy the full SHA 20c4364View commit details
Commits on Mar 25, 2015
-
Fixed tab-trap appearing in certain circumstances - Fixes T3686
Summary: Mathquill keeps track of a boolean `shouldBeSelected` based on the input to a `select` method, which determines if the textarea _should_ be selected and, if it isn't, reselects it. There is a bug where one can select the text in the box, continue typing, and not be able to escape with the tab key. This is because the combination of selecting all text and immediately typing does not reset the `shouldBeSelected` variable as it should. Instead, this variable only updates if the user selects the contents and hits "backspace." The fix for this was simple, we need to invoke `selectionChanged()` not only when the selection is deleted, but when it is replaced. Test Plan: I did the following in Perseus (thanks @aria for providing the repro steps) . Create two expression inputs . In the first, type something . Select all (Ctrl/Cmd-A) . Type again . Hit the tab key . See you are directed to the next expression input as expected Reviewers: emily, aria, john Reviewed By: john Subscribers: john, alex, aria, #a11y Maniphest Tasks: T3686 Differential Revision: https://phabricator.khanacademy.org/D16962
Configuration menu - View commit details
-
Copy full SHA for 8edd856 - Browse repository at this point
Copy the full SHA 8edd856View commit details