Merge pull request #52 from Afischbacher/develop #81
AfischbacherAnnotations
6 warnings
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
Nhl.Api.Domain/Models/Statistics/GoalieStatisticsFilterResult.cs#L175
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
Nhl.Api.Tests/NhlApiAsyncHelperTests.cs#L24
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
Nhl.Api.Domain/Models/Statistics/GoalieStatisticsFilterResult.cs#L175
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
Nhl.Api.Tests/NhlApiAsyncHelperTests.cs#L24
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|