Increase test coverage for src/sentences/utils.rs #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 37 37
Lines 1405 1405
=======================================
Hits 1095 1095
Misses 310 310 ☔ View full report in Codecov by Sentry. |
elpiel
requested changes
Sep 2, 2024
src/sentences/utils.rs
Outdated
Comment on lines
332
to
335
| let result = parse_number_in_range::<u8>("9", 10, 20); | ||
| assert!(result.is_err()); | ||
| let result = parse_number_in_range::<u8>("21", 10, 20); | ||
| assert!(result.is_err()); |
There was a problem hiding this comment.
It would be best to validate the returned error.
Right now the function might be returning a different that the out of range error.
elpiel
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect: #25