Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for sentences/utils.rs #25

Open
hargoniX opened this issue Jul 25, 2020 · 5 comments
Open

Tests for sentences/utils.rs #25

hargoniX opened this issue Jul 25, 2020 · 5 comments

Comments

@hargoniX
Copy link
Member

As per #11 we wanna ensure max test coverage, as of now sentences/utils.rs is not at all tested but shared across all sentence parsers and thus a source for very common bugs.

Should be quite easy to do and might be an easy way for an individual to look into tests and make a small open source commit unless someone really wants this in the crate quickly.

@elpiel
Copy link
Member

elpiel commented Jul 19, 2022

@gflow33 is picking up this issue to work on it.
If you have any questions or caveats you found, you can open a Draft PR or write here.

@elpiel
Copy link
Member

elpiel commented Sep 14, 2022

@gflow33 have you had any progress on this?

@gflow33
Copy link
Collaborator

gflow33 commented Sep 20, 2022

Yes I am still on this.

@trkohler
Copy link
Contributor

hello! is it still relevant?

@elpiel
Copy link
Member

elpiel commented Aug 24, 2024

Yes it is and we just hit a case where one of the parsers panics.

There are many places in the code where we could improve the error handling and also test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants