Update baselines.

Aerendir · Oct 10, 2024 · 1adfca2 · 1adfca2
1 parent a440cce
commit 1adfca2
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 13 deletions.
diff --git a/.baseline-phan.php b/.baseline-phan.php
@@ -11,31 +11,31 @@
     // # Issue statistics:
     // PhanDeprecatedFunction : 20+ occurrences
     // PhanUndeclaredMethod : 15+ occurrences
+    // PhanParamSignatureMismatch : 10+ occurrences
     // PhanTypeMismatchReturn : 10+ occurrences
     // PhanUnreferencedClosure : 9 occurrences
     // PhanTypeMismatchArgument : 8 occurrences
     // PhanUndeclaredProperty : 8 occurrences
     // PhanTypeMismatchDeclaredReturn : 6 occurrences
     // PhanUnreferencedProtectedMethod : 6 occurrences
-    // PhanParamSignatureMismatch : 4 occurrences
     // PhanTypeMismatchArgumentSuperType : 4 occurrences
     // PhanTypeMismatchReturnSuperType : 4 occurrences
     // PhanTypeMismatchArgumentNullable : 3 occurrences
     // PhanUnusedPublicFinalMethodParameter : 3 occurrences
     // PhanWriteOnlyPrivateProperty : 3 occurrences
     // PhanTypeArraySuspicious : 2 occurrences
     // PhanTypeMismatchDimAssignment : 2 occurrences
-    // PhanTypeMismatchPropertyReal : 2 occurrences
     // PhanUndeclaredTypeParameter : 2 occurrences
     // PhanUnusedVariable : 2 occurrences
     // ConstReferenceClassNotImported : 1 occurrence
+    // PhanAccessClassInternal : 1 occurrence
     // PhanCompatiblePHP7 : 1 occurrence
     // PhanPossiblyNullTypeMismatchProperty : 1 occurrence
     // PhanReadOnlyPrivateProperty : 1 occurrence
     // PhanTypeInvalidLeftOperandOfNumericOp : 1 occurrence
     // PhanTypeMismatchArgumentInternal : 1 occurrence
     // PhanTypeMismatchArgumentReal : 1 occurrence
-    // PhanTypeMismatchDimFetch : 1 occurrence
+    // PhanTypeMismatchPropertyReal : 1 occurrence
     // PhanTypeMismatchReturnNullable : 1 occurrence
     // PhanUnextractableAnnotationElementName : 1 occurrence
     // PhanUnextractableAnnotationSuffix : 1 occurrence
@@ -47,15 +47,16 @@
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
         'src/DependencyInjection/Configuration.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredMethod', 'PhanUnreferencedClosure', 'PhanUnusedVariable'],
-        'src/DependencyInjection/SHQFeaturesExtension.php' => ['PhanUnreferencedClass'],
+        'src/DependencyInjection/SHQFeaturesExtension.php' => ['PhanAccessClassInternal', 'PhanUnreferencedClass'],
         'src/Form/DataTransformer/AbstractFeatureTransformer.php' => ['PhanDeprecatedFunction'],
-        'src/Form/DataTransformer/BooleanFeatureTransformer.php' => ['PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'],
-        'src/Form/DataTransformer/CountableFeatureTransformer.php' => ['PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'],
-        'src/Form/DataTransformer/RechargeableFeatureTransformer.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod', 'PhanUnusedPublicFinalMethodParameter'],
+        'src/Form/DataTransformer/BooleanFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'],
+        'src/Form/DataTransformer/CountableFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'],
+        'src/Form/DataTransformer/FeaturesCollectionTransformer.php' => ['PhanParamSignatureMismatch'],
+        'src/Form/DataTransformer/RechargeableFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchArgument', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod', 'PhanUnusedPublicFinalMethodParameter'],
         'src/Form/Type/FeaturesType.php' => ['PhanTypeMismatchArgumentSuperType', 'PhanUndeclaredMethod', 'PhanUnreferencedClosure'],
         'src/InvoiceDrawer/AbstractInvoiceDrawer.php' => ['PhanWriteOnlyPublicProperty'],
         'src/Manager/FeaturesManager.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredMethod'],
-        'src/Manager/InvoicesManager.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchDimFetch', 'PhanTypeMismatchPropertyReal', 'PhanUndeclaredMethod', 'PhanWriteOnlyPrivateProperty'],
+        'src/Manager/InvoicesManager.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullable', 'PhanUndeclaredMethod', 'PhanWriteOnlyPrivateProperty'],
         'src/Model/Feature/AbstractFeaturesCollection.php' => ['PhanDeprecatedFunction', 'PhanUnreferencedClosure', 'PhanUnreferencedPublicClassConstant'],
         'src/Model/Feature/Configured/ConfiguredCountableFeature.php' => ['PhanReadOnlyPrivateProperty', 'PhanUnusedPublicFinalMethodParameter'],
         'src/Model/Feature/Configured/ConfiguredFeaturesCollection.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchDeclaredReturn', 'PhanUnreferencedProtectedMethod'],

diff --git a/.baseline-psalm.xml b/.baseline-psalm.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.24.0@462c80e31c34e58cc4f750c656be3927e80e550e">
+<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
   <file src="src/DependencyInjection/Configuration.php">
     <ArgumentTypeCoercion>
       <code><![CDATA[$currency]]></code>
@@ -28,6 +28,11 @@
       <code><![CDATA[children]]></code>
     </UndefinedMethod>
   </file>
+  <file src="src/DependencyInjection/SHQFeaturesExtension.php">
+    <InternalClass>
+      <code><![CDATA[Extension]]></code>
+    </InternalClass>
+  </file>
   <file src="src/Form/DataTransformer/AbstractFeatureTransformer.php">
     <MissingTemplateParam>
       <code><![CDATA[DataTransformerInterface]]></code>
@@ -37,6 +42,10 @@
     </PossiblyNullReference>
   </file>
   <file src="src/Form/DataTransformer/BooleanFeatureTransformer.php">
+    <MethodSignatureMismatch>
+      <code><![CDATA[BooleanFeatureTransformer]]></code>
+      <code><![CDATA[BooleanFeatureTransformer]]></code>
+    </MethodSignatureMismatch>
     <MoreSpecificImplementedParamType>
       <code><![CDATA[$enabled]]></code>
       <code><![CDATA[$feature]]></code>
@@ -50,6 +59,10 @@
     </RedundantCondition>
   </file>
   <file src="src/Form/DataTransformer/CountableFeatureTransformer.php">
+    <MethodSignatureMismatch>
+      <code><![CDATA[CountableFeatureTransformer]]></code>
+      <code><![CDATA[CountableFeatureTransformer]]></code>
+    </MethodSignatureMismatch>
     <MoreSpecificImplementedParamType>
       <code><![CDATA[$feature]]></code>
       <code><![CDATA[$pack]]></code>
@@ -60,6 +73,10 @@
     </ParamNameMismatch>
   </file>
   <file src="src/Form/DataTransformer/FeaturesCollectionTransformer.php">
+    <MethodSignatureMismatch>
+      <code><![CDATA[FeaturesCollectionTransformer]]></code>
+      <code><![CDATA[FeaturesCollectionTransformer]]></code>
+    </MethodSignatureMismatch>
     <MissingTemplateParam>
       <code><![CDATA[DataTransformerInterface]]></code>
     </MissingTemplateParam>
@@ -73,6 +90,10 @@
     </ParamNameMismatch>
   </file>
   <file src="src/Form/DataTransformer/RechargeableFeatureTransformer.php">
+    <MethodSignatureMismatch>
+      <code><![CDATA[RechargeableFeatureTransformer]]></code>
+      <code><![CDATA[RechargeableFeatureTransformer]]></code>
+    </MethodSignatureMismatch>
     <MoreSpecificImplementedParamType>
       <code><![CDATA[$feature]]></code>
       <code><![CDATA[$pack]]></code>
@@ -173,9 +194,6 @@
     </UndefinedInterfaceMethod>
   </file>
   <file src="src/Manager/InvoicesManager.php">
-    <InvalidPropertyAssignmentValue>
-      <code><![CDATA[$drawer]]></code>
-    </InvalidPropertyAssignmentValue>
     <InvalidReturnStatement>
       <code><![CDATA[$drawer]]></code>
     </InvalidReturnStatement>
@@ -377,7 +395,7 @@
       <code><![CDATA[$elements]]></code>
     </ImplementedParamTypeMismatch>
     <MethodSignatureMismatch>
-      <code><![CDATA[public function __construct(array $elements = [])]]></code>
+      <code><![CDATA[public function __construct(?array $elements = [])]]></code>
     </MethodSignatureMismatch>
     <MismatchingDocblockReturnType>
       <code><![CDATA[SubscribedBooleanFeature[]|SubscribedFeaturesCollection]]></code>