Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSM importer speedup #506

Merged
merged 34 commits into from
Feb 23, 2024
Merged

OSM importer speedup #506

merged 34 commits into from
Feb 23, 2024

Conversation

pedrocamargo
Copy link
Contributor

@pedrocamargo pedrocamargo commented Feb 5, 2024 •
edited
Loading

These speed-ups are going to be incredibly useful in building models automatically for Polaris and when creating models for large areas.

Jake-Moss
Jake-Moss reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Jake-Moss Jake-Moss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me though I'm not familiar is the OSM networks. The gist of the changes it does seem like it would be faster, a lot of python loops have been moved into pandas magic or similar

aequilibrae/project/network/osm/osm_builder.py Show resolved Hide resolved
aequilibrae/project/network/osm/osm_builder.py Show resolved Hide resolved
aequilibrae/project/network/osm/osm_builder.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Jake-Moss
Jake-Moss approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Jake-Moss Jake-Moss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pedrocamargo pedrocamargo merged commit 9fe62b8 into develop Feb 23, 2024
25 checks passed
@pedrocamargo pedrocamargo deleted the pedro/osm_importer_speedup branch February 23, 2024 04:07
Art-Ev added a commit to Art-Ev/aequilibrae that referenced this pull request Jul 17, 2024
@Art-Ev
Bringing back AequilibraE#464 after AequilibraE#506 overwritten it
452bedb 
Getting back bicycle lanes and bus lanes import from OSM
pedrocamargo pushed a commit that referenced this pull request Jul 17, 2024
@Art-Ev
Bringing back #464 after #506 overwritten it (#551)
11e6307 
Getting back bicycle lanes and bus lanes import from OSM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Moss Jake-Moss Jake-Moss approved these changes

@jamiecook jamiecook Awaiting requested review from jamiecook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrocamargo @Jake-Moss