[WIP] Feature/add netlify #430

Robert-SD · 2025-06-19T14:32:10Z

No description provided.

Robert-SD · 2025-06-19T14:32:38Z

.run/main_netlify.dart.run.xml

@@ -0,0 +1,7 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="main_netlify.dart" type="FlutterRunConfigurationType" factoryName="Flutter" nameIsGenerated="true">
+    <option name="additionalArgs" value="--dart-define=&quot;CLIENT_KEY=test_O3LEH54C3JDPREE3QOEPOCRG4QGEICBQ&quot; --dart-define=&quot;APPLE_PAY_MERCHANT_ID_KEY=demo&quot;" />


The client key is already public on the MyStoreDemo.

gemini-code-assist

Summary of Changes

Hello @Robert-SD, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Netlify environment setup alongside the existing example setup. It involves refactoring the main entry point to allow for different service implementations, creating separate entry points for each environment, and implementing a new service for Netlify. The changes also include updating project configurations and removing unnecessary fields from the session request body.

Highlights

Project Configuration: Added a new run configuration for main_netlify.dart and updated the existing main_example.dart configuration to reflect the file rename.
Entry Point Refactor: Refactored the main function in main_common.dart to mainCommon to allow different entry points for different environments (example and netlify).
New Entry Points: Created new entry point files main_example.dart and main_netlify.dart to use different service implementations.
Service Implementations: Introduced CheckoutService and NetlifyService to handle API calls for different environments.
Service Interface: Refactored Service from a class to an abstract interface to allow for different implementations.
Session Request Body: Removed unnecessary fields from the session request body in AdyenDropInRepository.
Widget Test: Updated widget test to import main_common.dart instead of main.dart.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-06-19T14:34:23Z

LCOV of commit `84080ec` during Check PR #1259

Summary coverage rate:
  lines......: 8.5% (136 of 1602 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

gemini-code-assist

Code Review

This pull request introduces support for a Netlify-based backend by refactoring the Service layer into an interface and providing two implementations (CheckoutService for the existing logic and NetlifyService for the new backend). It also updates main entry points and run configurations accordingly.

Key feedback points include a critical security issue with hardcoded API keys in a new run configuration, the need to implement several core methods in NetlifyService, considerations for a hardcoded base URL in NetlifyService, and a request for clarification on significant changes to the session request body. A minor point involves suggesting the use of a proper logger instead of print statements for better practice, even in an example application.

.run/main_netlify.dart.run.xml

gemini-code-assist · 2025-06-19T14:34:56Z

example/lib/network/netlify_service.dart

+    // TODO: implement deleteStoredPaymentMethod
+    throw UnimplementedError();


The method deleteStoredPaymentMethod (and several other methods in this NetlifyService class such as fetchPaymentMethods, postPayments, etc.) are currently stubbed out with // TODO: implement ... and throw an UnimplementedError.

While this is acceptable for work-in-progress, these methods represent core functionalities of the Service interface. For the NetlifyService to be fully functional and usable as an alternative backend, these methods will need to be implemented. Please ensure there's a plan or tracking issues to address these unimplemented parts.

example/lib/network/checkout_service.dart

gemini-code-assist · 2025-06-19T14:34:56Z

example/lib/network/netlify_service.dart

+  final baseUrl = "https://www.mystoredemo.io";
+
+  @override
+  Future<Map<String, dynamic>> createSession(Map<String, dynamic> body) async {
+    final http.Response response = await http.post(
+      Uri.parse('$baseUrl/.netlify/functions/sessions'),
+      body: jsonEncode(body),


The baseUrl is currently hardcoded. If this URL might change (e.g., for different deployment environments like development, staging, or production, or if the service endpoint itself changes), it would be more maintainable and flexible to make this configurable.

Consider moving it to a central configuration file (like config.dart, similar to Config.baseUrl) or sourcing it from environment variables. The suggestion below makes it a static const for now, which is slightly better if it's truly fixed for this service, but external configuration is generally preferred for URLs.

// Consider moving this to a central configuration if it can vary by environment. // For now, making it a private static const if it's fixed for this service. static const String _baseUrl = "https://www.mystoredemo.io"; @override Future<Map<String, dynamic>> createSession(Map<String, dynamic> body) async { final http.Response response = await http.post( Uri.parse('$_baseUrl/.netlify/functions/sessions'), // Use the static const body: jsonEncode(body), );

example/lib/repositories/adyen_drop_in_repository.dart

github-actions · 2025-06-20T14:51:50Z

LCOV of commit `4c568c4` during Check PR #1260

Summary coverage rate:
  lines......: 8.5% (136 of 1602 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2025-07-02T13:56:57Z

LCOV of commit `2dd02c3` during Check PR #1268

Summary coverage rate:
  lines......: 8.5% (136 of 1602 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2025-09-05T13:39:25Z

LCOV of commit `06600b1` during Check PR #1388

Summary coverage rate:
  lines......: 8.5% (136 of 1607 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

github-actions · 2025-09-10T08:58:50Z

LCOV of commit `c11e2bb` during Check PR #1396

Summary coverage rate:
  lines......: 8.5% (136 of 1603 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

…tion

sonarqubecloud · 2025-10-07T15:58:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Robert-SD · 2025-10-10T09:10:20Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the example app to support multiple backend services by introducing a Service interface, with implementations for the existing backend and a new Netlify-based one. It also adds the ability to configure the app via launch arguments, which is a great improvement for testing and flexibility. The changes are well-structured, but I've identified a few issues that need attention. A test API key is hardcoded in a run configuration, which is a security concern. There are also some leftover debug print statements that should be removed. Finally, as this is a work-in-progress, several methods in the new NetlifyService are unimplemented and will need to be completed.

gemini-code-assist · 2025-10-10T09:11:25Z

.run/main_netlify.dart.run.xml

@@ -0,0 +1,7 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="main_netlify.dart" type="FlutterRunConfigurationType" factoryName="Flutter" nameIsGenerated="true">
+    <option name="additionalArgs" value="--dart-define=&quot;CLIENT_KEY=test_O3LEH54C3JDPREE3QOEPOCRG4QGEICBQ&quot; --dart-define=&quot;APPLE_PAY_MERCHANT_ID_KEY=demo&quot;" />


Committing secrets to the repository, even if they are test keys, is a security risk. The hardcoded CLIENT_KEY should be removed from this run configuration. Please consider using a method that doesn't involve checking keys into version control, such as environment variables or a local configuration file that is ignored by git.

This is intended. It is our public client key from mystoredemo.io.

gemini-code-assist · 2025-10-10T09:11:25Z

example/lib/main_common.dart

+    Future.microtask(() async {
+      final String config =
+          await FlutterLaunchArguments().getString("config") ??
+              "FAILED TO FETCH CONFIG";
+      print("**** CONFIG FETCHED ****");
+      print(config);
+    });


This block appears to be for debugging purposes. It should be removed before merging the pull request. For logging during development, it's better to use debugPrint() instead of print() as it helps prevent log truncation on Android.

gemini-code-assist · 2025-10-10T09:11:25Z

example/lib/network/checkout_service.dart

+      headers: _createHeaders(),
+      body: jsonEncode(body),
+    );
+    print("PspReference: ${response.headers["pspreference"]}");


This print statement seems to be for debugging. It should be removed before this pull request is merged. For development logging, consider using debugPrint().

gemini-code-assist · 2025-10-10T09:11:25Z

example/lib/network/netlify_service.dart

+  Future<bool> deleteStoredPaymentMethod(
+      String storedPaymentMethodId, Map<String, dynamic> queryParameters) {
+    // TODO: implement deleteStoredPaymentMethod
+    throw UnimplementedError();
+  }


This method is currently unimplemented. While this is expected for a work-in-progress pull request, please ensure this and other methods throwing UnimplementedError in this file are fully implemented before the final merge.

Robert-SD commented Jun 19, 2025

View reviewed changes

gemini-code-assist bot reviewed Jun 19, 2025

View reviewed changes

Robert-SD changed the title ~~Feature/add netlify~~ [WIP] Feature/add netlify Jul 23, 2025

Robert-SD added 4 commits September 5, 2025 15:37

Started with netlify integration

29cfc0c

Started with adding the netlify endpoint

64acf41

Small adjustments

6355044

Added endpoint usage for advanced flow

06600b1

Robert-SD force-pushed the feature/addNetlify branch from 2dd02c3 to 06600b1 Compare September 5, 2025 13:37

Merge branch 'main' into feature/addNetlify

c11e2bb

Robert-SD added 7 commits September 12, 2025 15:59

Added flutter driver for appium and keys to buttons

18c2874

Merge branch 'main' into feature/addNetlify

e01a9e3

Prepared support launch arguments

bcd1ebf

Merge branch 'main' into feature/addNetlify

e642ad5

Used card config json value for card holder name

73255c7

Merge branch 'main' into feature/addNetlify

90b9991

Create config repository and mapped launch argument to card configura…

d46da7c

…tion

gemini-code-assist bot reviewed Oct 10, 2025

View reviewed changes

		// TODO: implement deleteStoredPaymentMethod
		throw UnimplementedError();

[WIP] Feature/add netlify #430

Are you sure you want to change the base?

[WIP] Feature/add netlify #430

Uh oh!

Conversation

Robert-SD commented Jun 19, 2025

Uh oh!

Robert-SD Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Jun 19, 2025

LCOV of commit 84080ec during Check PR #1259

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 20, 2025

LCOV of commit 4c568c4 during Check PR #1260

Uh oh!

github-actions bot commented Jul 2, 2025

LCOV of commit 2dd02c3 during Check PR #1268

Uh oh!

github-actions bot commented Sep 5, 2025

LCOV of commit 06600b1 during Check PR #1388

Uh oh!

github-actions bot commented Sep 10, 2025

LCOV of commit c11e2bb during Check PR #1396

Uh oh!

sonarqubecloud bot commented Oct 7, 2025

Quality Gate passed

Uh oh!

Robert-SD commented Oct 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Robert-SD Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

LCOV of commit `84080ec` during Check PR #1259

LCOV of commit `4c568c4` during Check PR #1260

LCOV of commit `2dd02c3` during Check PR #1268

LCOV of commit `06600b1` during Check PR #1388

LCOV of commit `c11e2bb` during Check PR #1396