Do not apply sanitization to root path when generating paths for downloaded assets in the cache folder#973
Do not apply sanitization to root path when generating paths for downloaded assets in the cache folder#973fthevenet wants to merge 1 commit intoAdoptOpenJDK:masterfrom
Conversation
…loaded assets in the cache folder.
|
@fthevenet we think removing the character "'" from INVALID_PATH list in FileUtils.java should fix the issue of "Foo_O'Bar" as "'" is a valid character for filepath in Windows. Can you please try this fix and resubmit the PR? |
|
I don't think this is the right approach even though it would indeed fix this particular occurrence. On the other hand, I think the |
This PR aims to address issue #972
Application launched via a JNLP file will failed to start for user wtih certain characters in their home folder (e.g.
C:\Users\Foo_O'Bar), which is a legal path on Windows, but paths for downloaded asset are incorrectly sanitize asC:\Users\Foo_O_Barand the application then fails as it attempts to access content inC:\Users\Foo_O_Bar\...instead ofC:\Users\Foo_OBar...