Extend JAVADOC_OPTS for Java 21+ (1.8)#970
Open
robert-scheck wants to merge 1 commit intoAdoptOpenJDK:1.8from
Open
Extend JAVADOC_OPTS for Java 21+ (1.8)#970robert-scheck wants to merge 1 commit intoAdoptOpenJDK:1.8from
robert-scheck wants to merge 1 commit intoAdoptOpenJDK:1.8from
Conversation
robert-scheck
changed the title
https://salsa.debian.org/java-team/icedtea-web/-/blob/master/debian/patches/jdk-21-autoconf.patch is a prerequisite, allows removing --ignore-source-errors from JAVADOC_OPTS being introduced with commit be98948.
Contributor
|
@robert-scheck As can be seen in the method getPredefinedJavaModulesVMArgumentsMap() of JvmUtils.java, there are additional jvm args required when running with Java 9+. Please add the missing arguments and resubmit the PR. |
Contributor
|
On the one hand the patch for acinclude.m4 is missing in the commit and on the other hand this breaks the build with Java 11. The 1.8 branch cannot be built with Java 21 anyway, so why the pull request here at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://salsa.debian.org/java-team/icedtea-web/-/blob/master/debian/patches/jdk-21-autoconf.patch is a prerequisite, allows removing
--ignore-source-errorsfromJAVADOC_OPTSbeing introduced with commit be98948.