-
Notifications
You must be signed in to change notification settings - Fork 88
fix links, whitespace #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting_started/first-app.md is not being used in this repo.
There is a src/pages/config.md is converted from the gatsby-config file. I'm not sure why but it seems the one you maybe thinking of is get_started/app_builder_get_started/first-app.md to modify this. Please check against those file.
Also because we do not have a local environment at this moment, I've deployed your files into stage so we can view it to make sure it works properly. https://developer-stage.adobe.com/app-builder/docs/get_started/ I've verified all your changes are good except the first-app.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates various Markdown documentation files to correct links and improve formatting consistency.
- Removes obsolete link references in requirements.md
- Reformats ordered list items in the extension migration guide
- Updates and fixes hook link in configuration.md
- Deletes first-app.md (verify if removal was intended)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/pages/resources/custom-asset-compute-worker/requirements.md | Removed two obsolete link reference definitions |
src/pages/guides/app_builder_guides/extensions/extension-migration-guide.md | Reformatted list numbering and clarified descriptions |
src/pages/guides/app_builder_guides/configuration/configuration.md | Updated hook link target and formatting |
src/pages/getting_started/first-app.md | Entire file deleted—confirm if this was intended |
Comments suppressed due to low confidence (2)
src/pages/guides/app_builder_guides/configuration/configuration.md:229
- The list item marker (
-
) was removed, which breaks the Markdown list structure. Please restore the leading-
bullet or proper indentation to keep this as part of the list.
Hooks can be used to customize `aio app` commands, as documented [hooks](../architecture_overview/app-hooks.md)
Thanks, I thought it was kinda dumb to have a getting_started/ and get_started/ |
Description
get-access -> ../get_started/app_builder_get_started/set-up.md#access
This PR updates documentation links and list formatting for clarity and consistency in various markdown files.
In requirements.md, an obsolete link reference is removed.
In extension-migration-guide.md, the ordered list items have been reformatted for clarity.
In first-app.md, the link to accessing App Builder has been updated to reflect the new file structure.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: