Cache node modules and meteor build #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnowack
force-pushed
the
caching
branch
7 times, most recently
from
c5358a3 to
05e9830
Compare
chdsbd
approved these changes
Aug 27, 2018
chdsbd
reviewed
Aug 27, 2018
chdsbd
suggested changes
Aug 27, 2018
|
Sorry for the long delay. I made the change you've requested :) |
|
Hi! Presuming there might be compiled packages within node_modules, you may need to also add handling to bust the cache for stack upgrades (eg have a cache signature that is based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added caching for development and production
node_modules. I'm also saving the cache, meteor generates during the build.Reusing that cache, reduced my build time from ~30 minutes to ~10 minutes (!)