Snowman Feedback - Iris Cheung

[apradoada]

No description provided.

[apradoada]

Hi Iris,
Welcome to your first Pull Request (PR)! We will talk more about pull requests during Unit 1, but they are a great tool we have on Github to easily view and provide feedback on changes that have been made to a repository. In industry, they are often used as a way for senior developers to provide feedback to junior developers on code they have written before that code gets merged into a deployed project. Here at Ada, we use it to provide feedback on your projects! Today, I've made the PR on your behalf, but in the future, you'll make your own and submit the link to that PR instead of a link to your project.

When it comes to the feedback I give, we use a scale of Red, Yellow, Green. They mean the following:
🟢 Green 🟢: Green projects pass all the tests and your code doesn't include anything that could cause the program to behave unexpectedly. The feedback on a green project is usually more stylistic in nature or geared toward making specific pieces of code more efficient and less repetitive. You are not required to implement the feedback, but you are welcome to if you want to! However, we likely won't have time to go back and assess the changes you have made. More generally, green projects indicate that we feel you have a strong grasp of the concepts covered in the project.

🟡 Yellow 🟡: Yellow projects typically pass all of the tests provided, but do include code that may indicate uncertainty about certain concepts or how the program works as a whole. This may include code logic that causes unexpected behavior in specific situations that aren't covered in our tests. Feedback on a yellow project may be geared more toward helping you understand why a particular piece of code may fail in those circumstances. Implementing this feedback is not required, but it it highly encouraged to help you recognize patterns and implement similar solutions in the future!

🔴 Red 🔴: Red projects typically do not pass all of the tests provided. Writing code that passes all tests is an element of Test Driven Development (TDD) that is often used within the tech industry. Feedback on a red project typically includes the same type of feedback you would see on a green or yellow project along with feedback to help you understand why your code is not passing all the tests and how you could get there. If you receive a red on a project, you will be required to implement the feedback so that all tests are passing! We will then reassess when the feedback has been implemented!

As far as Snowman goes, this project is a 🟢 Green 🟢! Great Job!

The feedback I have left is just a few things to think about, but overall the logic looks good! You are welcome to implement the changes if you would like! If you have any questions about any of the feedback I have provided, feel free to reach out and I am happy to explain further.

[apradoada]

With this particular program, we have two potential finish conditions: 1. We find the word, 2. We use up all our guesses. One is a win condition and one is a lose condition.

There are a couple different ways we could handle these two conditions:

1. Place both in a compound conditional within the while loop.
2. Use one as the while loop conditional and nest the other conditional within the while loop.

You have opted for the former, which Is good, but it does increase a bit of the work that needs to be done outside the loop. This happens for the following reasons:

If we check both for each iteration, our loop ends if either the win or lose condition is met. This means that we are going to have to make an additional and unnecessary check after the loop to see which condition was met. If we somehow resolved one win condition inside the loop, we would remove the need for extra checks after the while loop has complete.

If we meet one of the conditions inside the loop, we can exit the function early with an explicit return. This resolves one of our conditions that we no longer have to worry about later on.

Overall your approach works, but it does add a little bit of extra code!

[apradoada]

When it comes to writing Python code, one of the guides you'll see us reference is the PEP 8 Style Guide. This is a guide for best practices when it comes to styling our code. One of the most common things we see is to try and keep individual lines of code under 79 characters. This line currently goes past that limit! It won't cause the code to break or anything, but it is a good thing to keep in mind in terms of readability and best practices!

I currently see two possible fixes here:

1. Shorter and more concise variable names:

   • While there is no hard and fast rule on how long variable names should be, we could first try shortening the variable names we use here (correct_letter_guess_statuses and wrong_guesses_list) as they are on the longer side. That being said, these names match the parameters for the function you use to call them, which is good practice, so we'll need a different approach (but shorter variable names can help with this in other circumstances).

2. Restyle the Function Call:

   • This is a great trick to have up your sleeve when making a function call that either includes multiple parameters or starts to approach that 79 character line limit! We can drop the parameters to the next line(s) to look something like the following:
   Suggested change

   	user_input = get_letter_from_user(correct_letter_guess_statuses, wrong_guesses_list).lower()
   	user_input = get_letter_from_user(
   	correct_letter_guess_statuses,
   	wrong_guesses_list
   	).lower()
   • This is known as Implicit Line Continuation in Python. Whenever we have information nested inside parentheses, brackets or curly braces, we can drop the nested information to new lines without any specific notation!

[apradoada]

I just wanted to highlight a really cool thing that you did here! When we receive a letter from the user, we want to check to see if the letter exists within the word or not. Given the way this program is set up, we actually end up with two different collections that hold all the letters of the word, a string (snowman_word) and a dictionary (correct_letter_guess_statuses).

While we could check either one for the letter we've received, searching within a dictionary is ever so slightly more efficient than searching through a string (We'll talk more about why in Unit 1), so great choice here!

[apradoada]

Great choice to print both of these outside the conditionals!

[apradoada]

If we moved this conditional from where it currently is to inside the loop, we could handle one of the ending conditions inside the loop and remove it from the while conditionals. We could then exit the function early with an explicit return statement! That allows us only deal with the lose condition outside of the loop. In fact, we would know that the user has lost if the loop ends, so we could just include the print statement on line 43 outside the loop!

[apradoada]

This is a small thing, but make sure to remove the pass statements! It won't cause the code to fail or anything, but it is always best to remove unused code!