Tigers Kindra Greenawalt #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
styling finished for all pages, note the project buttons in portfolio are not linked anywhere yet though. |
spitsfire
reviewed
Jan 12, 2023
Contributor
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Nice job, Kindra! Your HTML looked very good!
Things to consider:
- Some of your css files had repeated styling, like
* {margin:0;padding:0;}. We could create a default css file that contains all the styling that would be seen on every html file. Then create a css file that is specific to each html file. - Some tags could be combined together to shorten repeated styling rules.
| @@ -0,0 +1,107 @@ | |||
| * {margin:0;padding:0;} | |||
Contributor
There was a problem hiding this comment.
While we can do this, let's stay consistent with the rest of our css:
*{
margin:0;
padding:0;
}| @@ -0,0 +1,107 @@ | |||
| * {margin:0;padding:0;} | |||
|
|
|||
| .container{ | |||
Contributor
There was a problem hiding this comment.
Great job using css grid! 👍
| background-color: darkgray; | ||
| grid-column: 1/3; | ||
| grid-row: 1/2; | ||
| display: flex; |
Contributor
There was a problem hiding this comment.
Great! Glad you see that we can combine flexbox and grid inside each other!
Comment on lines
+40
to
+47
| a:link{ | ||
| text-decoration: none; | ||
| color: lightgray; | ||
| } | ||
| a:visited{ | ||
| text-decoration: none; | ||
| color: lightgray; | ||
| } |
Contributor
There was a problem hiding this comment.
Hmm could we combine these, so we aren't repeating styling?
a:link,
a:visited{
text-decoration: none;
color: lightgray;
}
Comment on lines
40
to
47
| <br><br>I have a passion for continuous learning, process improvement, and coupling analytics with creativity to solve problems. | ||
| After completing my first course with SheCodes I found software engineering and web development fused my passions beautifully and became addicted! | ||
| <br><br> The learning didn't stop there, I'm now a proud C18 Adie with Ada Developers Academy graduating in August 2023. | ||
| Check out some of my projects, linked in my portfolio, to see what i've learned along the way. | ||
| </p> | ||
| </section> | ||
|
|
||
| <div class="image"> |
Contributor
There was a problem hiding this comment.
Maybe we can call this a section instead of a div
Comment on lines
+94
to
+96
| /* display: grid; | ||
| grid-template-columns: 1fr; | ||
| grid-template-rows: 1fr; */ |
Contributor
There was a problem hiding this comment.
Let's get rid of this:
Suggested change
| /* display: grid; | |
| grid-template-columns: 1fr; | |
| grid-template-rows: 1fr; */ |
| } | ||
|
|
||
| .project-description{ | ||
| /* grid-column: 1/2; */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /* grid-column: 1/2; */ |
| It is a landing page made from scratch incorporating a user interaction.</p> | ||
| <button>Load Project</button> | ||
| </div> | ||
| <!-- <img class ="image" src="https://s3.amazonaws.com/shecodesio-production/uploads/files/000/054/258/original/Screen_Shot_2022-11-17_at_10.15.40_AM.png?1668698584" alt="SheCodes weather app project"> --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- <img class ="image" src="https://s3.amazonaws.com/shecodesio-production/uploads/files/000/054/258/original/Screen_Shot_2022-11-17_at_10.15.40_AM.png?1668698584" alt="SheCodes weather app project"> --> |
| </p> | ||
| <button>Load Project</button> | ||
| </div> | ||
| <!-- <img class ="image" src="https://s3.amazonaws.com/shecodesio-production/uploads/files/000/054/253/original/Screen_Shot_2022-11-17_at_10.00.42_AM.png?1668697475" alt="SheCodes weather app project"> --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- <img class ="image" src="https://s3.amazonaws.com/shecodesio-production/uploads/files/000/054/253/original/Screen_Shot_2022-11-17_at_10.00.42_AM.png?1668697475" alt="SheCodes weather app project"> --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions