Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pages/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,26 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<title>Get to Know Bukunmi</title>
<!-- Link to Style Sheet -->>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for the extra > at the end of the comment. That's throwing off the validator.

<link href="styles/style.css" rel="stylesheet">

</head>
<body>

<nav>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nav often goes in the main header for the page.

<a href="index.html">Home</a>
<a href="about.html">About Me</a>
<a href="portfolio.html">Portfolio</a>
<a href="contact.html">Contact Me</a>
</nav>

<header>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good place for your nav.

</header>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the page would go here, maybe under a main tag.


<footer>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer is a useful spot for quick contact links, or copyright information.

</footer>
</body>
</html>
123 changes: 123 additions & 0 deletions pages/blog.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>A yr of Code Blog | Read me </title>
<link rel="stylesheet" href="styles/style.css">
<link rel="stylesheet" media="screen and (max-width: 768px)" href="css/mobile.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool way to pull in your mobile-specific styles, but your path is invalid (should be styles/mobile.css)

<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Lato&display=swap" rel="stylesheet">
</head>
<body class="blogmain">
<div class = "container">
<!-- Navbar and Page Menu -->
<div class="header box">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using header to a generic div.

<div class="logo">
<a class="logo" href="bloghome.html">
<img src="images/bloglogo.png.png" alt="Homepage">
</a>
<h1>
A year of Code Blog
</h1>
<ul class="listnav">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider wrapping this with a nav tag to mark that it's where the main navigation links are.

<li><a href="#">About</a></li>
</ul>
<ul class="listnav">
<li><a href="blog.html"> Most Current Blog Post</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put both li tags under the same ul.

</ul>
</div>
</div>
</div>
<div class="blogcontent">
<h2> BLOG TITLE Heading </h2>
<h5> Title description , DATE </h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumping from h2 to h5 makes me think these are being used primarily for their intrinsic styles. Prefer to use heading tags in order, and use style rules to adjust their look as desired.

<h5> Author -- Bukunmi G </h5>
<img class = "blogpostfoto" src= "images/blog2.jpg" alt="blog picture">
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit.
Architecto, ipsam excepturi necessitatibus similique dolores non consequuntur eos sequi, perferendis mollitia adipisci eveniet cum,
impedit minima alias provident cumque ipsum quos?.Lorem
</p>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Minus voluptatem placeat blanditiis
at et aliquid architecto adipisci ipsa
maxime nesciunt perspiciatis quaerat labore, quidem velit vel fugiat
esse id? Veniam.
</p>
<figure>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of figure to associate the image with a caption.

<img src="images/blog3.jpg" alt="coding">
<figcaption><b> Fig.1 - Me Procastinating before I start coding away.</b></figcaption>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid legacy style tags, including b, i, and u. Set things like bold, italic, or underline using styles.

</figure>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Minus voluptatem placeat blanditiis
at et aliquid architecto adipisci ipsa
maxime nesciunt perspiciatis quaerat labore, quidem velit vel fugiat
esse id? Veniam.
</p>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Minus voluptatem placeat blanditiis
at et aliquid architecto adipisci ipsa
maxime nesciunt perspiciatis quaerat labore, quidem velit vel fugiat
esse id? Veniam.
</p>
<blockquote>“I wish for a world that views disability, mental or physical, not as a hindrance but as unique attributes
that can be seen as powerful assets if given the right opportunities. Accessability in
technology is a basic human right. Let us advance digital equity together. ”
</blockquote>
<span>&#10077;</span>
<i> Anywhere I see suffering, that is where I want to be, doing what I can</i>
<span>&#10080;</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might want 10078 here. 80 gives me a broken glyph.

<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to use margin styling to handle spacing between elements rather than stacking br tags.

<br>
<hr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hr is considered semantic when conveying a shift in topic or scene in a longer section of text, but should not be used solely for its visual effect, which can be accomplished through border styling. From MDN:

The <hr> HTML element represents a thematic break between paragraph-level elements: for example, a change of scene in a story, or a shift of topic within a section.

<br>
<br>
<div class="containerbio">
<img class="avatar" src="images/avatar.png" alt="bukunmi's avatar">
<p>Bukunmi is <u>a public health professional and programmer</u>
spending a year to expand her programming knowledge. Come learn and laugh with her....
</p>
</div>
</div>
</div>
</body>
<footer id="main-footer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer must come within the body element. This currently causes a validation error.

<div class="footercontainer">
<!--The content you put in footer-->
<div>
<img src="images/bloglogo.png.png" alt="logo">
</div>
<div class="newsletter">
<h3> Email Newletter</h3>
<span>Subscribe for future updates</span>
<form>
<input type="email" placeholder="Enter Email...">
<input type="submit" value="subscribe" class="btn">
</form>
</div>
<div>
<h3> Blog Links</h3>
<ul class="list">
<li><a href="#">Who is Bukunmi?</a></li>
<li><a href="#">Most recent Blog post</a></li>
<li><a href="#">Bukunmi's portfolio</a></li>
<li><a href="#">Bukunmi's Git page</a></li>
</ul>
</div>
<div>
<h3> Follow Me</h3>
<ul class="list">
<li><a href="#">Linkedin</a></li>
<li><a href="#">Twitter</a></li>
<li><a href="#">Instagram</a></li>
<li><a href="#">Github</a></li>
</ul>
</div>
<div>
<p>
Copyright &copy; 2022 and beyond. All Rights Reserved.
</p>
</div>
</div>
</footer>
</html>
155 changes: 155 additions & 0 deletions pages/bloghome.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>A yr of Code Blog | Read me </title>
<link rel="stylesheet" href="styles/style.css">
<link rel="stylesheet" media="screen and (max-width: 768px)" href="styles/mobile.css">
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Lato&display=swap" rel="stylesheet">
</head>
<body>
<div class = "container">
<!-- Navbar and Page Menu -->
<div class="header box">
<div class="logo">
<a class="logo" href="bloghome.html">
<img src="images/bloglogo.png.png" alt="Homepage">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep your image names clean. This picked up and extra file extension.

</a>
<h1>
A year of Code Blog
</h1>
<ul class="listnav">
<li><a href="#">About</a></li>
</ul>
<ul class="listnav">
<li><a href="blog.html"> Most Current Blog Post</a></li>
</ul>
</div>
</div>
</div>
<!-- Blog showcase/most current posting-->
<div>
<div class="showcasebox">
<div class="showcasecontent">
<h1><span>Blog Post title</span></h1>
<p><span>Lorem ipsum dolor sit, amet consectetur adipisicing elit. Incidunt quidem est itaque doloremque
facere culpa velit quo a assumenda. Repudiandae id aliquid vel eaque praesentium architecto
distinctio quis in pariatur.</span>
</p>
<a href="blog.html" class="btn"> Read More</a>
</div>
</div>
<!-- Old Blog Posts-->
<section class="postcontainer">
<h2 class="mostread"><span>Most Read Posts</span></h2>
<div class="posts">
<article class="card">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of article to represent each blog entry.

<div class="order">
<img src="images/blog1.jpg" alt="woman">
</div>
<div>
<h3>
<a href="#"> Lorem impsum dolor sit</a>
</h3>
<p>
Lorem, ipsum dolor sit amet consectetur adipisicing elit. Impedit quis similique nemo omnis,
perspiciatis laborum soluta libero nihil vitae doloremque facere, animi laboriosam, tenetur
ipsum qui illo neque! Vel, fugiat!
</p>
</div>
</article>
<article class="card">
<div class="order">
<img src="images/blog2.jpg" alt="woman">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the alt tag describes the image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to resize images to be lower resolution. If the image data is much larger than the size it will be displayed at, this causes the visitor to consume more data than necessary, and slows down displaying the page (large images are harder for the browser to display and take some time to resize).

</div>
<div>
<h3>
<a href="#"> Lorem impsum dolor sit</a>
</h3>
<p>
Lorem, ipsum dolor sit amet consectetur adipisicing elit. Impedit quis similique nemo omnis,
perspiciatis laborum soluta libero nihil vitae doloremque facere, animi laboriosam, tenetur
ipsum qui illo neque! Vel, fugiat!
</p>
</div>
</article>
<article class="card">
<div class="order">
<img src="images/Banner.png" alt="woman">
</div>
<div>
<h3>
<a href="#"> Lorem impsum dolor sit</a>
</h3>
<p>
Lorem, ipsum dolor sit amet consectetur adipisicing elit. Impedit quis similique nemo omnis,
perspiciatis laborum soluta libero nihil vitae doloremque facere, animi laboriosam, tenetur
ipsum qui illo neque! Vel, fugiat!
</p>
</div>
</article>
<article class="card">
<div class="order">
<img src="images/blog3.jpg" alt="woman">
</div>
<div>
<h3>
<a href="#"> Lorem impsum dolor sit</a>
</h3>
<p>
Lorem, ipsum dolor sit amet consectetur adipisicing elit. Impedit quis similique nemo omnis,
perspiciatis laborum soluta libero nihil vitae doloremque facere, animi laboriosam, tenetur
ipsum qui illo neque! Vel, fugiat!
</p>
</div>
</article>
</div>
</section>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra closing div tage here.

</body>
<footer id="main-footer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other file, footer needs to be within the body element.

<div class="footercontainer">
<!--The content you put in footer-->
<div>
<img src="images/bloglogo.png.png" alt="logo">
</div>
<div class="newsletter">
<h3> Email Newletter</h3>
<span>Subscribe for future updates</span>
<form>
<input type="email" placeholder="Enter Email...">
<input type="submit" value="subscribe" class="btn">
</form>
</div>
<div>
<h3> Blog Links</h3>
<ul class="list">
<li><a href="#">Who is Bukunmi?</a></li>
<li><a href="#">Most recent Blog post</a></li>
<li><a href="#">Bukunmi's portfolio</a></li>
<li><a href="#">Bukunmi's Git page</a></li>
</ul>
</div>
<div>
<h3> Follow Me</h3>
<ul class="list">
<li><a href="#">Linkedin</a></li>
<li><a href="#">Twitter</a></li>
<li><a href="#">Instagram</a></li>
<li><a href="#">Github</a></li>
</ul>
</div>
<div>
<p>
Copyright &copy; 2022 and beyond. All Rights Reserved.
</p>
</div>
</div>
</footer>
</html>
Empty file added pages/contact.html
Empty file.
Binary file added pages/images/Banner.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pages/images/avatar.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pages/images/blog1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pages/images/blog2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pages/images/blog3.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pages/images/bloglogo.png.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 54 additions & 0 deletions pages/styles/mobile.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/* Nav Bar */
.listnav {
display: none;
}

/* Main Blog Post */
.showcasecontent h1,
p {
font-weight: bold;
justify-content: left;
inline-size: 80%;
}

.showcasecontent span {
background: rgba(255, 240, 0, 0.6);
}

.showcasecontent {
padding: 2rem;
background: url("../images/Banner.png") no-repeat center center/cover;
top: 0;
left: 0;
width: 80%;
height: 100%;
}

/* Blog page post*/
.blogpostfoto {
width:85%;
height: 100%;
}

.containerbio {
flex-direction: column;
}

/* Most Read Posts Cards */
.card p,
h3 {
inline-size: 95%;
font-size: smaller;
}

.card h3 {
font-size: small;
text-align: center;
}

/* Footer */
.list,
.newsletter,
.footercontainer h3 {
display: none;
}
Loading