Skip to content

Queues - Sahana Murthy - Trek #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sahanamurthy
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means the code is not executed according to the written order, but is executed based on event calls.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I think the Clickhandler function executes asynchronously. I added it within the document ready function so that it would be executed only when called.
What kind of errors might the API give you? How did you choose to handle them? The API might tell us that the request didn't go through. I added in a more readable error.
What is an Underscore template? Describe one template you used for this project. Underscore allows us to access javascript code within an HTML file. I used one to access and display a Trip object's details.
Do you have any recommendations on how we could improve this project for the next cohort? Maybe make the CSS part optional? Also maybe a little more guidance on the layout page. I think I spent a day and a half trying to figure out the slideToggle event. :(

@PilgrimMemoirs
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done
Functionality
Click a button to list trips Well Done
Click a trip to see trip details Well Done
Fill out a form to reserve a spot ❗️ Almost - Submits form, but should stay on the same page instead of redirecting to the herokuapp's page.
Errors are reported to the user Mostly Good - .fail is being called on ajax requests, however not all are errors are being output in the browser. Like with getting more information on an individual trip, it is only outputting to console.
Styling, Foundation grid layout Well Done
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read Well Done
HTML is semantic Okay - Should be using more semantic sectioning tags like <header>, <main> and <aside>
All dynamic content is rendered using Underscore templates Well Done - Mixing your template code within your other, static, HTML makes it hard to read and distinguish what is static vs what is a template. It's better practice, and cleaner, to have the templates defined below your static HTML.
Overall
Great job at completing almost all requirements to standards. The biggest area for improvement is to make sure a user is staying on your index.html page when submitting the form. Also be mindful of how errors are presented to users and to continue using semantic HTML sectioning tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants