Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sofia Kim - rails-zoo #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Sofia15
Copy link

@Sofia15 Sofia15 commented Apr 3, 2017

Rails Zoo

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words the Rails request/response cycle for viewing an animals detail page View is composed of html and erb that is wrapped in <% %> or <%= %>. When an user requests the web application by typing its URL into the browser, the browser sends a GET request to the routes.rb file, and view files would be rendered depending on which action the controller routes.
Describe one area of Rails that you gained more clarity on with this assignment Relationship among route/controller/view
Is there a specific piece of code you'd like more feedback on? Not really
What is one aspect of this project that surprised you? Not surprising, but this project was really helpful for me to follow along with what we did for a week with previous projects. I now have a better understanding of the basics and nature of rails.

@PilgrimMemoirs
Copy link

PilgrimMemoirs commented Apr 7, 2017

Rails Zoo

What We're Looking For

Feature Feedback
Appropriate Git usage with no extraneous files checked in ❗️ Need more commits
Answered comprehension questions Mostly Good - Where does the model come into play?
Naming conventions: controller is plural, model is singular Well Done
Overall
❗️ Had error with: No route matches [POST] "/animals/11/edit". That route should be using a GET HTTP method - a button defaults to POST, so you will need to specify GET to call the appropriate route.
Be mindful of where you use instance vs local variables - does destroy, update or create need to use instance variables?
Here's a good resource on how all the parts work with each other http://paulhan221.tumblr.com/post/114731592051/rails-http-requests-for-mvc This graphic is particularly good: http://68.media.tumblr.com/c2838d3c5306ebcbcac0e85a5a05533a/tumblr_inline_nlus00X7JT1t9vfbl_500.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants