-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queues - Hyunji Kim - Static-Site #27
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have really strong git commits!
Lovely photos ❤️
I am truly amazed by your CSS work. I had to look up many of your syntax and selectors. (Maybe I should go back to ADA for a review?).
</nav> | ||
</span> | ||
</header> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome usage of <div>
and <span>
here in the <header>
section. You know the difference well!
<section id="hero"> | ||
<img src="../images/mommy.jpg" class = "bounce-in-top" alt="hero image"> | ||
<h1 class = "dropshadow">It's Me!</h1> | ||
<p class="center-p"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this start.html
and index.html
. Which one is the homepage?
<link href ="../styles/styles.css" rel="stylesheet"> | ||
</head> | ||
<body id="about"> | ||
<main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor comment: A navigation bar at the top of each page would help me go back and forth between your website pages more easily. :)
<link href ="../styles/styles.css" rel="stylesheet"> | ||
</head> | ||
<body> | ||
<main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a navigation bar here?
<link href ="../styles/normalize.css" rel="stylesheet"> | ||
<link href ="../styles/styles.css" rel="stylesheet"> | ||
</head> | ||
<body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a navigation bar here?
line-height: 1.15; /* 2 */ | ||
-ms-text-size-adjust: 100%; /* 3 */ | ||
-webkit-text-size-adjust: 100%; /* 3 */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 👍
line-height: 0; | ||
position: relative; | ||
vertical-align: baseline; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 👍
[type="reset"], | ||
[type="submit"] { | ||
-webkit-appearance: button; /* 2 */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 👍
[type="submit"]::-moz-focus-inner { | ||
border-style: none; | ||
padding: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[type="reset"]:-moz-focusring, | ||
[type="submit"]:-moz-focusring { | ||
outline: 1px dotted ButtonText; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions