Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addie's Static Site #23

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

add2point71dots
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I forgot an alt tag on one of my images. It also gave me a couple of warnings about some sections not having headings and to only use h1 as a top-level heading only, since I have an h1 outside of my header that's visible in computer and tablet mode (the one in the header is only visible on mobile).
Why is it important to consider and use semantic HTML? It's important for making the code more readable (for others and yourself), and probably more importantly for accessibility reasons. Screen readers will get more information from semantic HTML. It also helps google know what's important on your page.
How did you decide to structure your CSS? I put the main structural stuff that applies to every page at the top, mostly in order of how it appears on the screen. Then I put classes that affected structure across different pages, and then non-structural elements, page-specific css, a clearfix class, and classes to hide/show elements on mobile view.
What was the most challenging piece of this assignment? Design! And making design decisions! I definitely spent more time than I should have on design...especially since I'm still not in love with how it came out. Also: coming up with content! (You may notice my blog pages currently have placeholder images and lorem ipsum because I ran out of time.)
Describe one area that you gained more clarity on when completing this assignment Using web developer tools. I think I'd used something similar before, but probably not to its full potential, so I had fun playing around with inspecting different elements and searching for rogue padding and margins.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Check
Answered comprehension questions Check
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Exactly 4
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Good use of semantic HTML
All images include alternate text Check
CSS
Using class and ID names in style declarations Check
Style declarations are DRY Pretty good!
Overall The pages are nice & clean, I like the transition effects on the menu and the rounded images. I would suggest your email icon at the bottom link to you email address with <a href="mailto:[email protected]"></a> Instead of linking to your about-me page.

Copy link

@livmaria7891 livmaria7891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean HTML and CSS. Very readable class and id names. Seems like you have an excellent understanding of reusing your CSS. You might consider using using 'em' or 'rem' over 'px' for responsiveness (although your site resized very nicely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants