Brenna's Static Site #19
Conversation
Static SiteWhat We're Looking For
|
| I'm Brenna (not Brenda or Brianna or Greta) Darroch (pronounced like Arrow)! I love making art, reading, writing, and coding. I'm currently a student at Ada Developers Academy, learning Ruby, HTML/CSS, Ruby on Rails, and Javascript. On the side, I'm teaching myself game programming. | ||
| </p> | ||
| <p> | ||
| Fun fact: I know the following musicals by heart: Grease, Sound of Music, My Fair Lady, Phantom of the Opera, West Side Story, and Fiddler on the Roof. Currently working on Hamilton. :) |
There was a problem hiding this comment.
👍 You're my hero!!! I absolutely LOVE musicals!
| <img src="images/portfolio.png" alt="Art Portfolio" /> | ||
| <p class="desc"> | ||
| Using HTML, CSS, and Javascript Lightbox, I coded my art portfolio site. | ||
| </p> |
There was a problem hiding this comment.
This is repetitive, but I don't see it on your actual webpage. Not sure if I'm looking at the right place 🤔
| <link href="styles/normalize.css" rel="stylesheet"> | ||
| <link href="styles/styles.css" rel="stylesheet"> | ||
|
|
||
| <!-- favicon didn't work! |
There was a problem hiding this comment.
favicons are such a pain, amiright??
| color: #09B3C4; | ||
| } | ||
|
|
||
| h1 a, h2, h4 { |
| } | ||
|
|
||
| *, *:before, *:after { | ||
| box-sizing: inherit; |
There was a problem hiding this comment.
I'm not sure that this line is necessary...does this do the same as lines 8-10?
| padding: 0 2.5%; | ||
| } | ||
|
|
||
| .prof { |
There was a problem hiding this comment.
does this refer to any of the classes in your html file? Can't find its reference anywhere
| } | ||
|
|
||
| section.contact img { | ||
| width: 50px; |
There was a problem hiding this comment.
maybe even add the footer img selector here to make it more dry!
| @@ -0,0 +1,139 @@ | |||
| /* color1: #09B3C4 */ | |||
There was a problem hiding this comment.
You might not use it at ADA but if you use sass (different but similar to css) you can make these constants so you can declare them once and refer to them everywhere! (makes changing the color soooo easy in the future!)
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions