Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regan's random menu generator #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Regan's random menu generator #24

wants to merge 1 commit into from

Conversation

pancake-batfish
Copy link

Mood Analysis

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Would a hash work just as well as an Array in this project? Why? I don't see any place that a hash would be helpful in this problem -- there's nothing that seems to need a key-value pair for storage or access
Did you find yourself repeating the same code? Why did you have to do it that way? I'd like a more concise way to declare the initial three arrays and the array of arrays, but I'm not yet aware of one. In my initial more simple version of the program, I was able to do the "generate menu items" step without repetitively defining the first_word, second_word variables `10.times {
What type of loop did you use? Why did you choose that type? I used times loops for the input of words to the arrays and for the output of menu items because I had a set user-defined number of times that these loops needed to iterate. I used a while loop for the input of the number of items on the menu so I could easily check for compliance with the maximum and repeat until the user complied.

@kariabancroft
Copy link

Random Menu

What We're Looking For

Feature Feedback                                                                              
Random Menu of 10 items displayed in the terminal. Check
Generator pulls one random item from each array to create menu items. Check
Baseline
Readable code with consistent indentation. Well done
Extras
User can enter their own words Check
User can pick the number of menu items Check

Summary

Overall, well done. Nice work on the extras.

Note: You can probably avoid the while true loop by looping unless (items <= options) && (items > 0)

Nice ASCII Art.

FYI: This is Chris on Kari's Account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants