Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janice's Jackpot Menu #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Janice's Jackpot Menu #20

wants to merge 1 commit into from

Conversation

janicewilson
Copy link

Homework assignment.

Mood Analysis

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Would a hash work just as well as an Array in this project? Why? Assuming the method sample works similarly for hashes, yes. None of my code was based upon index position.
Did you find yourself repeating the same code? Why did you have to do it that way? I did. I wasn't terribly thoughtful due to a time crunch. But I used a gazillion while loops, which wasn't terribly efficient. I probably could have used an array within an array to be more succinct.
What type of loop did you use? Why did you choose that type? Times and while. Just the first that came to mind.

Homework assignment.
@kariabancroft
Copy link

kariabancroft commented Feb 10, 2017

Random Menu

What We're Looking For

Feature Feedback                                                                              
Random Menu of 10 items displayed in the terminal. Check
Generator pulls one random item from each array to create menu items. check
Baseline
Readable code with consistent indentation. Well done.
Extras Good work with the number of items and user entered words. Nice work
Issues The loops you used to ensure uniqueness (line 166) seem to go forever. I might suggest popping each word off the array as it's used instead, so no word is used twice. Methods were not really required for this, but you could also have used them to provide some logical separation on the tasks performed and to make it more modular (easier to change).

Summary

Overall very well done. Nice work on the extras!

-- BTW This is Chris on Kari's account.

@janicewilson
Copy link
Author

I want to make certain I thought through this correctly. Nothing should be repeated as used elements are shoved into a used_### array. If future elements sampled are included in this array, they will not be stored, than interpolated. It runs correctly. Is there a circumstance within which it doesn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants