Cedar - Maria Obregon Garcia #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Sep 29, 2021
Comment on lines
+59
to
+72
| if user_data["watched"]: | ||
| # populate watched_genres freq map | ||
| for movie in user_data["watched"]: | ||
| genre = movie["genre"] | ||
| if genre in watched_genres: | ||
| watched_genres[genre] += 1 | ||
| else: | ||
| watched_genres[genre] = 1 | ||
| # find max frequency and paired genre | ||
| max_watched_genre_freq = max(watched_genres.values()) | ||
| for genre, freq in watched_genres.items(): | ||
| if freq == max_watched_genre_freq: | ||
| most_watched_genre = genre | ||
| return most_watched_genre |
There was a problem hiding this comment.
You can clean this up a little bit with an early return (personally I find extra indentation makes functions a little harder to read):
Suggested change
| if user_data["watched"]: | |
| # populate watched_genres freq map | |
| for movie in user_data["watched"]: | |
| genre = movie["genre"] | |
| if genre in watched_genres: | |
| watched_genres[genre] += 1 | |
| else: | |
| watched_genres[genre] = 1 | |
| # find max frequency and paired genre | |
| max_watched_genre_freq = max(watched_genres.values()) | |
| for genre, freq in watched_genres.items(): | |
| if freq == max_watched_genre_freq: | |
| most_watched_genre = genre | |
| return most_watched_genre | |
| if not user_data["watched"]: | |
| return None | |
| # populate watched_genres freq map | |
| for movie in user_data["watched"]: | |
| genre = movie["genre"] | |
| if genre in watched_genres: | |
| watched_genres[genre] += 1 | |
| else: | |
| watched_genres[genre] = 1 | |
| # find max frequency and paired genre | |
| max_watched_genre_freq = max(watched_genres.values()) | |
| for genre, freq in watched_genres.items(): | |
| if freq == max_watched_genre_freq: | |
| most_watched_genre = genre | |
| return most_watched_genre |
Comment on lines
+77
to
+90
| # non-assigned helper function | ||
| def create_user_watched_set(user_data): | ||
| user_watched_set = set() | ||
| for movie in user_data["watched"]: | ||
| user_watched_set.add(movie["title"]) | ||
| return user_watched_set | ||
|
|
||
| # non-assigned helper function | ||
| def create_friends_watched_set(user_data): | ||
| friends_watched_set = set() | ||
| for friend in user_data["friends"]: | ||
| for movie in friend["watched"]: | ||
| friends_watched_set.add(movie["title"]) | ||
| return friends_watched_set |
Comment on lines
+93
to
+97
| if not movie["title"] in user_watched_set: | ||
| movie_not_in_user_watched = True | ||
| else: | ||
| movie_not_in_user_watched = False | ||
| return movie_not_in_user_watched |
There was a problem hiding this comment.
You can condense this down because in produces a boolean:
Suggested change
| if not movie["title"] in user_watched_set: | |
| movie_not_in_user_watched = True | |
| else: | |
| movie_not_in_user_watched = False | |
| return movie_not_in_user_watched | |
| return not movie["title"] in user_watched_set |
| recommended_movies = [] | ||
| user_watched_set = create_user_watched_set(user_data) | ||
| movie_rec = {} | ||
| already_recommended = [] |
There was a problem hiding this comment.
If you make already_recommended a set then this is more efficient.
Comment on lines
+112
to
+113
| movie_rec = {"title": movie["title"], "host": movie["host"]} | ||
| recommended_movies.append(movie_rec) |
There was a problem hiding this comment.
You can use the original movie here instead of creating a new one:
Suggested change
| movie_rec = {"title": movie["title"], "host": movie["host"]} | |
| recommended_movies.append(movie_rec) | |
| recommended_movies.append(movie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.