Cedar - Mac Madison #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Sep 29, 2021
Comment on lines
+5
to
+9
| """ | ||
| Returns: | ||
| new_movie (dict): A dictionary initialized with title (str), genre (str), and rating (float). | ||
| Returns None if any parameters are falsy. | ||
| """ |
| user_data (dict): The updated user_data with movie added to "watched" and movie removed from "watchlist". | ||
| """ | ||
|
|
||
| watch_list = user_data.get("watchlist") |
Comment on lines
+12
to
+13
| new_movie = {"title": title, "genre": genre, "rating": rating} | ||
| return new_movie |
There was a problem hiding this comment.
Generally if I'm going to return it on the next line I don't assign to a variable:
Suggested change
| new_movie = {"title": title, "genre": genre, "rating": rating} | |
| return new_movie | |
| return {"title": title, "genre": genre, "rating": rating} |
Comment on lines
+81
to
+88
| def get_user_titles(user_data): | ||
| """ | ||
| Returns: | ||
| user_titles (set): A set containing all movie titles in user's "watched" list. | ||
| """ | ||
|
|
||
| user_titles = set([movie.get("title") for movie in user_data.get("watched")]) | ||
| return user_titles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.