Dani Sanchez - Paper #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 4, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work Dani, this works well. I left a little commentary on small things, but overall a solid submission.
Comment on lines
+26
to
+32
| if self.size == self.buffer_size: | ||
| raise QueueFullException() | ||
|
|
||
|
|
||
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.store[self.rear] = element | ||
| self.size += 1 |
|
|
||
| return_value = self.store[self.front] | ||
| self.store[self.front] = None | ||
| self.front += 1 |
There was a problem hiding this comment.
One correction
Suggested change
| self.front += 1 | |
| self.front = (self.front + 1) % self.buffer_size |
Comment on lines
+80
to
+89
| if self.rear < self.front: | ||
| items_str = ", ".join(str(self.store[item]) for item in range(self.front, self.size - 1)) | ||
| second_set_items = ", ".join(str(self.store[item]) for item in range(-1, self.rear + 1)) | ||
| joined_items = "[" + items_str + ", " + second_set_items + "]" | ||
| return joined_items | ||
|
|
||
| else: | ||
| items_str = ", ".join(str(self.store[item]) for item in range(self.front, self.rear + 1)) | ||
| joined_items = "[" + items_str + "]" | ||
| return joined_items |
There was a problem hiding this comment.
This is a little overcomplicated. You could instead start an index at self.front, and change it by current_index = (current_index + 1) % self.buffer_size adding each item to your output until you reach self.rear
| self.store = LinkedList() | ||
|
|
||
| def push(self, element): | ||
| """ Adds an element to the top of the Stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation