Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BayDAG Contribution #13: Estimation Mode Usability #779

Merged
merged 3 commits into from
Apr 1, 2024
Merged

BayDAG Contribution #13: Estimation Mode Usability #779

merged 3 commits into from
Apr 1, 2024

Conversation

dhensle
Copy link
Contributor

@dhensle dhensle commented Dec 18, 2023

This PR contains a small collection of miscellaneous estimation mode usability enhancements:

  • Fixes bug in stop frequency model that checks to see if the trips are in created in ActivitySim but not the survey.
  • Allows the user to specify estimation data bundles that they do not want to write to disk.
  • Handles empty EDBs incase a model has not choosers (can occur for really small sample sizes).
  • Better error messaging and checking when loading data into larch, specifically around empty EDBs and size term selection in location choice models
  • Allow comments in stop frequency spec when loading EDB into larch.

Required for SANDAG ABM3 production? -- No

@dhensle dhensle self-assigned this Jan 30, 2024
@dhensle dhensle force-pushed the BayDAG_cont13_est_mode_usability branch from 6b3a118 to e8144af Compare March 11, 2024 21:11
@jpn-- jpn-- merged commit 0a119ad into ActivitySim:main Apr 1, 2024
18 checks passed
@dhensle dhensle deleted the BayDAG_cont13_est_mode_usability branch April 23, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-am-sijia i-am-sijia i-am-sijia approved these changes

Assignees

@dhensle dhensle

Labels
None yet
Projects
Phase 9 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhensle @i-am-sijia @jpn--