-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to write output tables as parquet files #763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few suggested small changes to make this code more future-developer-friendly.
|
||
'h5_store' defaults to False, which means the output will be written out to csv. | ||
'file_type' defaults to 'csv' but can also be used to specify 'parquet' or 'h5'. | ||
When 'h5_store' is set to True, 'file_type' is ingored and the outputs are written to h5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old setting should now be deprecated. I opened an issue #791 to address that separate from this PR.
This PR adds the option to write output tables as parquet files, as described in this issue/feature request.