Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit chunking #759

Merged
merged 25 commits into from
Feb 6, 2024
Merged

Explicit chunking #759

merged 25 commits into from
Feb 6, 2024

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Nov 23, 2023 •
edited
Loading

This PR adds an explicit chunking option to the compute_accessibility component.

jpn-- and others added 20 commits April 4, 2023 07:02
@jpn--
explicit-chunk
61d8d13
@jpn--
try to limit RAM eating
4da37bd
@jpn--
pin to pandas<2 for now
a1f9c9a
@jpn--
Merge branch 'generic-whale' into explicit-chunk
a63e886 
# Conflicts:
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	conda-environments/github-actions-tests.yml
@jpn--
fix for explicit chunk
d152f37
@jpn--
Merge branch 'generic-whale' into explicit-chunk
e05b03a
@jpn--
Merge branch 'generic-whale' into explicit-chunk
19a4f1a
@jpn--
log error and traceback on fail
05b57a4
@jpn--
Merge branch 'generic-whale' into explicit-chunk
099edd7
@jpn--
Merge branch 'generic-whale' into explicit-chunk
7ea23b8
@jpn--
merge updates
81e3cd7
@jpn--
docstrings and annotations
8059fe1
@jpn--
Merge commit '81e3cd71eb548a293e947b77d99cb54c505c3d13' into explicit…
c487838 
…-chunk-latest

# Conflicts:
#	activitysim/abm/models/accessibility.py
#	activitysim/core/chunk.py
@jpn--
blacken
88d9885
@jpn--
Merge commit '2ff39b8829858e102a7ed27a32b16e73895575e5' into explicit…
7a7ee04 
…-chunk-with-config
@jpn--
fix bug in tracing
f5ce553
@jpn--
omg windows
327d97b
@jpn--
Merge branch 'repair-larch-2' into repair-larch
b20517c 
# Conflicts:
#	conda-environments/github-actions-tests.yml
@jpn--
use default when SIZE_TERM_SELECTOR is explicitly None
0330fbe
@jpn--
Merge branch 'develop' into explicit-chunk-with-config
3742f57
@jpn-- jpn-- added the Phase 8 Feature planned for inclusion in Phase 8 release label Jan 30, 2024
@jpn-- jpn-- requested a review from stefancoe February 2, 2024 18:35
stefancoe
stefancoe approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@stefancoe stefancoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I tested with and without chunking using PSRC's implementation and am getting the same results. @jpn-- does the documentation need anything beyond what will get updated via documentation build?

@jpn--
Copy link
Member Author

jpn-- commented Feb 6, 2024

does the documentation need anything beyond what will get updated via documentation build?

Yes, we do need to write a much better user's guide on how to use chunking. Since this PR only includes explicit chunking for a single component, I've not taken that on yet (i.e. in this PR) but it does include documentation attached as docstrings to the "explicit_chunk" settings for the AccessibilitySettings class, and in the doc embedded in the chunk.py file.

@jpn-- jpn-- merged commit 69465d9 into ActivitySim:develop Feb 6, 2024
18 checks passed
@jpn-- jpn-- mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefancoe stefancoe stefancoe approved these changes

Assignees
No one assigned
Labels
Phase 8 Feature planned for inclusion in Phase 8 release
Projects
Phase 9 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpn-- @stefancoe