-
Notifications
You must be signed in to change notification settings - Fork 117
RuntimeError consolidation #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JoeJimFlood
wants to merge
20
commits into
ActivitySim:main
Choose a base branch
from
camsys:error-consolidation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a spec table that's created for a specific segment
…Error to DuplicateWorkflowNameError
… be raised if tours are being input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reclassifies most of the generic
RuntimeError
exceptions that were described in Issue #692. It includes new exceptions that were created based on an inventory of the existingRuntimeErrors
:SettingsConfiguratonError
: There is an error with the entire modeling system, likely caused by something not being correct in the run's settings file (settings.yaml if not otherwise specified).ModelConfigurationError
: Something is wrong with the configuration of a model step.InvalidTravelError
: ActivitySim is unable to create a trip or tour that has the necessary attributes. For example, this error will be raised if a joint tour that is supposed to have both children and adults traveling can't force at least one of each on the tour.TableSlicingError
: There was some issue with slicing a table in the pipeline while setting up multiprocessing.SubprocessError
: One of the subprocesses failed while multiprocessing. The user will then need to check that process' log to see exactly what the error was.SegmentedSpecificationError
: An error occurred while creating the specification for a segmented model component. This is unlikely to occur in production.TableIndexError
: There was an issue involving the index of a skim or table stored in memory, such as if a desired origin is not in a skim.EstimationDataError
: There is something wrong with the data used in estimation mode.InputTableError
: There is an issue with one of the input tables to the model. For example, this will be raised if not every record in the input persons table has a household ID within the households table.These were created from identifying recurring patterns in an inventory of existing
RuntimeErrors
within the ActivitySim source code. The context surrounding each exception was analyzed which was used to determine the appropriate exception (if there were to be a change). It would be greatly appreciated if reviewers could think of the following questions when reviewing: