Skip to content

fix: issue #2738 - #2743

Merged
deadlyjack merged 2 commits into
mainfrom
fix/2738
Aug 14, 2026
Merged

fix: issue #2738#2743
deadlyjack merged 2 commits into
mainfrom
fix/2738

Conversation

@deadlyjack

Copy link
Copy Markdown
Member

show cancel button instantly when loading files for remote files.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR improves remote-file loading by immediately exposing cancellation and displaying locally cached content while the remote read completes.

  • Uses a zero-delay cancel control for FTP and SFTP directory loading.
  • Displays editor-recovery or transport-cache content as a temporary remote-file preview.
  • Adds remote-loading tab styling and unit coverage for preview-cache selection.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/pages/fileBrowser/fileBrowser.js Separates the loader delay from the timer handle, resolving the previously reported duplicate declaration while showing remote cancellation immediately.
src/lib/editorFile.js Adds remote-file preview loading and tab loading-state management around the existing file lifecycle.
src/lib/editorManager.js Adds a loading-preview event that renders cached remote text in the appropriate editor pane.
src/utils/remoteFilePreview.js Selects editor recovery data before the optional transport cache and tolerates transport-cache failures.
tests/unit/remoteFilePreview.test.js Covers cache precedence, missing and unreadable transport caches, and recovery-cache read failures.

Reviews (2): Last reviewed commit: "fix: syntax issue, preview loading delay..." | Re-trigger Greptile

Comment thread src/pages/fileBrowser/fileBrowser.js Outdated
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptileai review again

@UnschooledGamer UnschooledGamer added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Aug 14, 2026
@github-actions github-actions Bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Aug 14, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Preview Release for this, has been built.

Click here to view that github actions build

@deadlyjack
deadlyjack added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit baa6f8e Aug 14, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 14, 2026
@deadlyjack
deadlyjack deleted the fix/2738 branch August 14, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants