fix: migration - #2741
Merged
deadlyjack merged 2 commits intoAug 14, 2026
Merged
Conversation
Contributor
Greptile SummaryThe PR moves legacy terminal-home migration from sandbox initialization into a retryable JavaScript migration routine.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported failed-copy completion issue is fixed because a copy failure exits nonzero, rejects the executor promise, and prevents both the marker and in-memory completion guard from being set. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Terminal startup or file-browser storage listing] --> B{Migration already completed?}
B -->|Yes| C[Return]
B -->|No| D[Copy legacy home]
D -->|Failure| E[Reject and leave migration retryable]
D -->|Success or absent| F[Copy legacy root]
F -->|Failure| E
F -->|Success or absent| G{Any legacy content copied?}
G -->|Yes| H[Create .migrated marker]
G -->|No| I[Finish without marker]
H --> J[Set in-memory completion guard]
I --> J
Reviews (2): Last reviewed commit: "Update src/plugins/terminal/www/Terminal..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Member
Author
Merged
via the queue into
Acode-Foundation:main
with commit Aug 14, 2026
78f5d44
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.