Skip to content

fix: migration - #2741

Merged
deadlyjack merged 2 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:fix/terminal-home-migration
Aug 14, 2026
Merged

fix: migration#2741
deadlyjack merged 2 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:fix/terminal-home-migration

Conversation

@RohitKushvaha01

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves legacy terminal-home migration from sandbox initialization into a retryable JavaScript migration routine.

  • Copies legacy alpine/home and alpine/root contents into separate public/MIGRATE subdirectories.
  • Creates the completion marker only after all attempted copies succeed.
  • Invokes migration during terminal startup and when terminal-backed storage is exposed in the file browser.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported failed-copy completion issue is fixed because a copy failure exits nonzero, rejects the executor promise, and prevents both the marker and in-memory completion guard from being set.

Important Files Changed

Filename Overview
src/plugins/terminal/www/Terminal.js Adds the migration routine and correctly propagates copy failures through the background executor before setting completion state.
src/plugins/terminal/scripts/init-sandbox.sh Removes the former unconditional move into the merged public directory in favor of the structured migration routine.
src/pages/fileBrowser/fileBrowser.js Triggers legacy migration when exposing terminal public storage in the standalone file browser.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Terminal startup or file-browser storage listing] --> B{Migration already completed?}
    B -->|Yes| C[Return]
    B -->|No| D[Copy legacy home]
    D -->|Failure| E[Reject and leave migration retryable]
    D -->|Success or absent| F[Copy legacy root]
    F -->|Failure| E
    F -->|Success or absent| G{Any legacy content copied?}
    G -->|Yes| H[Create .migrated marker]
    G -->|No| I[Finish without marker]
    H --> J[Set in-memory completion guard]
    I --> J
Loading

Reviews (2): Last reviewed commit: "Update src/plugins/terminal/www/Terminal..." | Re-trigger Greptile

Comment thread src/plugins/terminal/www/Terminal.js
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@RohitKushvaha01

Copy link
Copy Markdown
Member Author

@greptile

@RohitKushvaha01 RohitKushvaha01 added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Aug 14, 2026
@github-actions github-actions Bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Aug 14, 2026
@Acode-Foundation Acode-Foundation deleted a comment from github-actions Bot Aug 14, 2026
@Acode-Foundation Acode-Foundation deleted a comment from github-actions Bot Aug 14, 2026
@deadlyjack
deadlyjack added this pull request to the merge queue Aug 14, 2026
Merged via the queue into Acode-Foundation:main with commit 78f5d44 Aug 14, 2026
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants