Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoVDB v32.7.0 with DCO Fix #1861

Merged

Conversation

apradhana
Copy link
Contributor

PR-1807 contains a DCO sign-off error. This PR is a copy of that PR with the DCO Fix.

From initial comment by @kmuseth:
Introducing NanoVDB v32.7.0, which is a major refactoring of v32.6, primarily related to the introduction of new namespaces and an accompanying restructuring of the directory layout of header files. This will likely require changes to client code! To this end I have included a shell script (cmd/updateFiles.sh) that will scan files and make (most) of the required changes.

The motivation for there these changes is twofold: First we want to use the same practice in terms of name spaces as OpenVDB and second the old version (32.6) was getting cluttered and messy. Specifically the main changes are:

  1. Virtually everything in NanoVDB is no using nanovdb as a namespace
    2[ Additionally the following nested namespaces are introduced: math, tools, cuda, io
  2. these namespaces are reflected in matching restructures in the directories of header files as well as names of functions, kernels and a classes.
    Here are some examples of changes:
nanovdb::CpuTimer -> nanovdb::util::Timer
nanovdb::GpuTimer -> nanovdb::util::cuda::Timer
nanovdb::gridStats -> nanovdb::tools::gridStats
nanovdb::Coord -> nanovdb::math::Coord

@apradhana
Copy link
Contributor Author

PR-1807 has gone through a thorough code-review process, which should carry over to this PR.

@apradhana apradhana merged commit aea0f0e into AcademySoftwareFoundation:master Jul 16, 2024
10 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants