Various Fixes #1768
Merged
Various Fixes #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Idclip
commented
Feb 26, 2024
•
Idclip
commented
- Fixed an incorrect assert in Mat4.h. This should fix the debug CI.
- Fixed an issues caused by 6ce7033 (basically we want to prefer jemalloc, but don't use the one shipped by Houdini on MacOS). This should fix the Houdini CI stalling.
Signed-off-by: Nick Avramoussis <[email protected]>
Signed-off-by: Nick Avramoussis <[email protected]>
…ed by 6ce7033) Signed-off-by: Nick Avramoussis <[email protected]>
Idclip
requested review from
kmuseth,
apradhana,
jmlait,
danrbailey and
richhones
as code owners
danrbailey
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.