Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::any with std::any #1687

Merged

Conversation

bpmckinnon
Copy link
Contributor

Replace BOOST_STATIC_ASSERT with static_assert

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Idclip
Copy link
Contributor

Idclip commented Oct 14, 2023

Thanks a lot @bpmckinnon! I actually tried to fix this years ago with our metadata implementation (linking just for future reference #744) but happy to accept this change instead.

Do you think you can sign off your commits and fill out the CLA?

I think you're right in that all that's left is the conversion_traits header (and it would be nice to have our own iostream/interprocess impl), we can look to solve that too.

@bpmckinnon
Copy link
Contributor Author

I'm working on the CLA. I was doing this as part of work, so I'm looking for a corporate manager for the CLA.

@bpmckinnon bpmckinnon force-pushed the ReplaceBoostAnyWithStdAny branch 3 times, most recently from 9c009f3 to 6cbea05 Compare October 16, 2023 13:20
Replace BOOST_STATIC_ASSERT with static_assert

Signed-off-by: Brian McKinnon <[email protected]>
@bpmckinnon bpmckinnon force-pushed the ReplaceBoostAnyWithStdAny branch from 6cbea05 to c00edd5 Compare October 16, 2023 13:28
@Idclip
Copy link
Contributor

Idclip commented Oct 18, 2023

I'm working on the CLA. I was doing this as part of work, so I'm looking for a corporate manager for the CLA.

No worries, keep us posted - we can contribute these changes on your behalf but would be nicer if you're able to get it signed

@bpmckinnon
Copy link
Contributor Author

Alright, this should be ready to go

@Idclip Idclip merged commit 70145ae into AcademySoftwareFoundation:master Oct 24, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants