Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing log4cplus/version.h include #1641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vimproved
Copy link

Currently, the logging.h header checks the LOG4CPLUS_VERSION macro to determine whether to use std::auto_ptr or std::unique_ptr. However, the LOG4CPLUS_VERSION macro is defined in log4cplus/version.h, which is not explicitlyincluded from logging.h. Explicitly include log4cplus/version.h to ensure that the LOG4CPLUS_VERSION macro is defined.

Currently, the logging.h header checks the LOG4CPLUS_VERSION macro to
determine whether to use std::auto_ptr or std::unique_ptr. However, the
LOG4CPLUS_VERSION macro is defined in log4cplus/version.h, which is not
explicitlyincluded from logging.h. Explicitly include
log4cplus/version.h to ensure that the LOG4CPLUS_VERSION macro is
defined.

Signed-off-by: Violet Purcell <[email protected]>
@vimproved vimproved requested a review from kmuseth as a code owner July 11, 2023 18:55
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@Idclip Idclip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks, lgtm - we should probably bump our log4cplus min version to 2.X anyway (which would remove the need to use this macro)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants