Fix C++20 compatibility by removing deprecated shared_ptr::unique() #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jérémie Dumas <[email protected]>
|
It seems the CI failed due to a transient network issue with vcpkg? Can a maintainer rerun the failed workflow? |
Idclip
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
lgtm, thanks @jdumas (@danrbailey might be worth adding a release note for C++20 conformance with MSVC)
|
I'm a bit puzzled by the CI issue. Seems like a network issue but it occurred twice on the same Windows job. It's been a while though so could we try to rerun it again? |
|
Hi there. Can we merge this? |
Yeah we can ignore this failure
Needs two maintainer approvals. @danrbailey |
Merged
danrbailey
approved these changes
Sep 26, 2023
danrbailey
merged commit d41e3a5
into
AcademySoftwareFoundation:master
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1590.