Various Fixes around SIOF #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idclip
requested review from
richhones,
danrbailey,
kmuseth,
apradhana and
jmlait
as code owners
…oblems Signed-off-by: Nick Avramoussis <[email protected]>
…s and missing virtual methods Signed-off-by: Nick Avramoussis <[email protected]>
Signed-off-by: Nick Avramoussis <[email protected]>
Signed-off-by: Nick Avramoussis <[email protected]>
danrbailey
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all cases of file static/global variables which relied on non-trivial construction into function scopes as static locals. These would previously initialize themselves on start-up in a non deterministic, compiler dictated order (static-initialization-order-fiasco). This order is now defined by the program's execution.