Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colourspace example for more complete coverage #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barretpj
Copy link
Contributor

Example now includes 3 plugins, to exercise Basic, Core and Full styles.

@revisionfx
Copy link
Contributor

Thanks

Is there a difference between?:
ROLE(kOfxColourspaceRoleColorTiming, "Color Timing role (Arbitrary scene log)"),
ROLE(kOfxColourspaceRoleCompositingLog, "Compositing Log role (Arbitrary scene log)"),
Is there a difference between?:
ROLE(kOfxColourspaceRoleMattePaint, "Matte Paint role"),
ROLE(kOfxColourspaceRoleTexturePaint, "Texture Paint role (Typically sRGB)"),

@barretpj
Copy link
Contributor Author

Is there a difference between?: ROLE(kOfxColourspaceRoleColorTiming, "Color Timing role (Arbitrary scene log)"), ROLE(kOfxColourspaceRoleCompositingLog, "Compositing Log role (Arbitrary scene log)"), Is there a difference between?: ROLE(kOfxColourspaceRoleMattePaint, "Matte Paint role"), ROLE(kOfxColourspaceRoleTexturePaint, "Texture Paint role (Typically sRGB)"),

Not relevant to this PR. These are the spaces/roles define in the OCIO config we use.

@Guido-assim
Copy link
Contributor

These plugins are very nice to check the behavior of the host :-).
Maybe a hypothetical case, but if the plugin specifies a basic color space as an output color space then the host doesn't know what the exact color space is that is used. The host might need to convert the output of the plugin to another color space for display or other reasons.

@john-paulsmith
Copy link
Contributor

Maybe a hypothetical case, but if the plugin specifies a basic color space as an output color space then the host doesn't know what the exact color space is that is used. The host might need to convert the output of the plugin to another color space for display or other reasons.

Not specifically relevant to this PR, but my recommendations would be:

  1. Plug-ins should use cross-referencing for the output clip unless absolutely necessary.
  2. When using the basic style, plug-ins should not perform colourspace transformations to anything other than ofx_raw (e.g. motion vectors).
  3. If the plug-in does set a basic colourspace on the output clip, the host should interpret that in the same way it would if it was supplying images to the plug-in using that basic colourspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants