-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for issue #98 (Cuda/Metal/OpenCL properties) #101
Changes for issue #98 (Cuda/Metal/OpenCL properties) #101
Conversation
I don't seem to have privs to link this PR to the issue, I see no cog icon in the Development sidebar :-( |
You can always just mention the issue number like this: should fix #98. That will create enough of a link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will submit a cleaned up version of this PR without the intermediate changes and reverts.
I cherry-picked the relevant commits onto main. Closing this as merged. Thanks, Phil! |
I said I didn't know what I was doing with PRs, and maybe this proves it - despite my best efforts it's still showing 5 old commits in the list, although they have no effect on the diff.