-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set CMAKE_DEBUG_POSTFIX if in a subproject #1987
base: main
Are you sure you want to change the base?
Don't set CMAKE_DEBUG_POSTFIX if in a subproject #1987
Conversation
… it will set this variable if OpenEXR is a subproject
…y. Avoid useless rebuilds after cmake reconfigure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Could I ask for a second set of eyes on the DEFLATE change please?
This looks good to me, thanks. @Debitsch-Faro, our project policy is to require a Contributor License Agreement (CLA) and Digital Certificate of Origin (DCO), i.e. signed commits, hence the check failures. Could you kindly sign the CLA through the form at the red "NOT COVERED" box above? And for the DCO, please amend your commit with the
You'll obviously need to do a Thanks for the contribution, and your patience with the contribution requirements. |
Signed-off-by: Rasmus Debitsch <[email protected]>
c44668d
to
29e5f45
Compare
Hope this works now. This is my first github pull-request. Sorry for any extra work from your side. |
Close! The CLA is in place, but unfortunately all 3 commits need to be signed. to get past the DCO check. Probably the easiest thing to do is merge the 3 commits into a single one, then sign that one. I use |
One additional small request: can you change the name of the PR to something more descriptive, e.g. "Don't set CMAKE_DEBUG_POSTFIX if in a subproject". The PR name will appear in the release notes, and "Fix 1981" won't mean much. Use the "edit" button to the right of the PR title. Thanks! |
Don't add the CMAKE_DEBUG_POSTFIX variable to the cache
When using OpenEXR as an subproject this overwrites the settings of other subprojects.
Change header file only when necessary
Cmake configure rewrites the libdeflate lib_common.h header file. This triggers rebuilds when reconfiguring a cmake project. E.g. The cmake tools of vscode trigger a reconfigure of a project when something is changed in one of the projects cmake files. Then the header file is written and a rebuild of the deflate library is triggered.