Add an option to use TBB as the global provider #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does NOT change the default thread pool provider if you manually instantiate a thread pool, as that would change the contract of the previous definition of the thread pool and likely cause deadlocks when users expected separate threads in separate thread pools Signed-off-by: Kimball Thurston <[email protected]>
The code was normally fine, but potentially problematic depending on thread provider to delete the thread pool prior to waiting for all the tasks to finish Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
meshula
reviewed
Oct 2, 2024
cmake/OpenEXRSetup.cmake
Outdated
| @@ -42,6 +42,11 @@ option(OPENEXR_INSTALL_PKG_CONFIG "Install OpenEXR.pc file" ON) | |||
| # Whether to enable threading. This can be disabled, although thread pool and tasks | |||
| # are still used, just processed immediately | |||
| option(OPENEXR_ENABLE_THREADING "Enables threaded processing of requests" ON) | |||
| # will use TBB for the global thread pool by default | |||
There was a problem hiding this comment.
This comment's kinda confusing ~ the option is OFF (which is what I would expect) but the comment says TBB is used by default, which is only true if the option is ON.
meshula
reviewed
Oct 2, 2024
website/install.rst
Outdated
| use case), but TBB shares actual threads and uses an arena to control | ||
| thread usage. | ||
|
|
||
| To enable this, simple set the flag during config: |
There was a problem hiding this comment.
spelling: simply
maybe just omit the word simple/y :)
Signed-off-by: Kimball Thurston <[email protected]>
meshula
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My dev days contribution :)
This was inspired based on #1285, although does not use a TBB task group to do any sync at this point, as if someone were to provide an alternate thread pool provider, the task group would then fail miserably. Additionally, this only sets the global thread pool provider to the TBB one to retain the previous contract where creating a thread pool actually created threads.
Can be enabled with -DOPENEXR_USE_TBB=ON added to cmake
Website preview: https://openexr--1852.org.readthedocs.build/en/1852/