Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core changes for cpp rewrite #1724

Merged

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Apr 20, 2024

These are changes to the core library needed for the C++ library to leverage the core more fully. Some of this might need to change prior to release, but should be fine to start

Website preview: https://openexr--1724.org.readthedocs.build/en/1724/

kdt3rd added 6 commits April 20, 2024 12:53
Add additional API for querying information from the context for
integration into the C++ code base. These should be reviewed prior to
final release whether they need to persist or are only temporary

Signed-off-by: Kimball Thurston <[email protected]>
Not sure when that got added to the C++ library, but wasn't in the core

Signed-off-by: Kimball Thurston <[email protected]>
Long name attribute flags was not being set correctly and the rules
around when there is a mismatch between the bit flags in the header and
the type attribute were not being correctly handled

Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@kdt3rd kdt3rd merged commit 94bf6ca into AcademySoftwareFoundation:main Apr 20, 2024
35 checks passed
@kdt3rd kdt3rd deleted the core_changes_for_cpp_rewrite branch April 20, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants