Fix version tag for python wheel sdist #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cary Phillips <[email protected]>
| @@ -39,6 +39,8 @@ jobs: | |||
| - name: Create sdist | |||
| # Only create it once. | |||
| if: ${{ matrix.os == 'ubuntu-latest' }} | |||
| env: | |||
| OPENEXR_RELEASE_CANDIDATE_TAG: ${{ github.ref_name }} | |||
There was a problem hiding this comment.
Shouldn't this be set only for release candidates?
There was a problem hiding this comment.
Good point, I removed it. Technically it doesn't matter since the result would be the same, since the release tag will be the same as the version, but logically the RELEASE_CANDIDATE_TAG should not play a part here. Thanks!
Signed-off-by: Cary Phillips <[email protected]>
JeanChristopheMorinPerso
approved these changes
Feb 15, 2024
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2024
* Fix version tag for sdist Signed-off-by: Cary Phillips <[email protected]> * Don't set OPENEXR_RELEASE_CANDIDATE_TAG for the non-test publish Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Mar 4, 2024
* Fix version tag for sdist Signed-off-by: Cary Phillips <[email protected]> * Don't set OPENEXR_RELEASE_CANDIDATE_TAG for the non-test publish Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sdist wasn't picking up the dynamically-generated version from the tag name, so wasn't getting published.