fix: the argument parsing function copies a command-... in...#207
Open
orbisai0security wants to merge 3 commits into
Open
fix: the argument parsing function copies a command-... in...#207orbisai0security wants to merge 3 commits into
orbisai0security wants to merge 3 commits into
Conversation
The argument parsing function copies a command-line argument string directly into a fixed-size destination buffer (ops->val) using strcpy, which performs no length validation
Collaborator
|
How about return error in case of too long string input? |
Author
done. |
Collaborator
|
BTW, the function "args_set_variable_by_key_long( )" supports 'non' string value arguments, like; Have you checked this cases? |
…y_key_long For non-STRING opts (INTEGER, FLAG), sizeof(var) evaluates to sizeof(pointer) rather than sizeof(int), producing a misleading val_len of 8. Since val_len is only read in the ARGS_VAL_TYPE_STRING branch of args_read_value(), zero it for all other types to make the invariant explicit and prevent future misuse. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
addressed. pls review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
app/oapv_app_args.h.Vulnerability
V-001app/oapv_app_args.h:127Description: The argument parsing function copies a command-line argument string directly into a fixed-size destination buffer (ops->val) using strcpy, which performs no length validation. Because the source string (argv) is entirely attacker-controlled and its length is unbounded, an attacker can supply an argument longer than the allocated destination buffer, overflowing it and overwriting adjacent memory including return addresses, function pointers, or heap metadata.
Changes
app/oapv_app_args.hVerification
Automated security fix by OrbisAI Security