Adding AMD ROCm 4.5 to the common image. #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The supported linux driver is upcoming. Let me see if I can find more info |
|
Hi! Thanks for the contribution, do you know if rocm would work in the same docker image as the one we use which already contain the NVIDIA drivers? Have you been able to test the resulting image? |
| @@ -24,8 +25,8 @@ docker_commands: | | |||
| RUN mkdir /opt/aswf | |||
| WORKDIR /opt/aswf | |||
|
|
|||
| ENV LD_LIBRARY_PATH=/usr/local/lib:/usr/local/lib64:/opt/rh/httpd24/root/usr/lib64:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/lib64:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/lib:${LD_LIBRARY_PATH} \ | |||
| PATH=/opt/rh/rh-git218/root/usr/bin:/usr/local/bin:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/bin:/opt/app-root/src/bin:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/bin/:/usr/local/sbin:/usr/sbin:/usr/bin:/sbin:/bin \ | |||
| ENV LD_LIBRARY_PATH=/opt/rocm/lib:/usr/local/lib:/usr/local/lib64:/opt/rh/httpd24/root/usr/lib64:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/lib64:/opt/rh/devtoolset-${ASWF_DTS_VERSION}/root/usr/lib:${LD_LIBRARY_PATH} \ | |||
There was a problem hiding this comment.
For safety I would prefer if you added the rocm path at the end of the LD_LIBRARY_PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all!
This is the first time figuring out how the aswf-docker image works, so I apologise if I didn't do it quite right!
This adds AMD ROCm https://rocmdocs.amd.com/en/latest/ to the image. ROCm/HIP is GPU compute on AMD hardware, similar to Nvidia's CUDA.
I would like to build Cycles-X with ROCm support so this would be great to add into the main image. I've yet to get this running yet (it does build) but I thought I'd put up a PR to see if I've got this working mostly correct...
@bsavery
Cheers!