Fix for find_children() with stacks

[darbyjohnston]

Fixes #1652

After some investigation, it looks like the find_children() function was not working with stacks when given a search range. To fix this, an override is added for the function children_in_range() that works with "stacks" of children.

[jminor]

This is a great find & a clear fix.
Skimming the history of the codebase, I think this bug has existed since before the port from Python to C++. The implementation of children_in_range in Composition only works correctly for Tracks. This bug was likely introduced by the bisection optimization, but I didn't look back that far in the history to confirm.
I wonder if there's a general implementation that could go into Composition, and only the optimized one could be in Track, but since there are only 2 subclasses of Composition anyways, I think your fix is great and should be long lived.

[darbyjohnston]

Thanks, I think the bug did predate the C++ port since the confidence tests didn't cover it. That's an interesting point about the optimization, If the bisect code was for Python it would be interesting to test how much it helps in C++.

[jminor]

Oh, I thought of one other edge case... Could you try this with a Track that has a source_range trim on it? I suspect that the new function you made might need to use trimmed_range_in_parent instead of trimmed_range.

[darbyjohnston]

I didn't realize tracks could have a source range, how does that affect the clips? If the track source range duration is shorter than the clips, are they trimmed?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (c0e97b0) to head (d8ab747).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   84.11%   81.68%   -2.44%     
==========================================
  Files         198      176      -22     
  Lines       22241    12342    -9899     
  Branches     4687     3023    -1664     
==========================================
- Hits        18709    10082    -8627     
+ Misses       2610     1718     -892     
+ Partials      922      542     -380     

Flag	Coverage Δ
py-unittests	81.68% <88.23%> (-2.44%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/opentimelineio/composition.h	65.51% <ø> (ø)
src/opentimelineio/stackAlgorithm.cpp	56.70% <100.00%> (ø)
...opentimelineio/opentimelineio/adapters/__init__.py	85.18% <100.00%> (-2.32%)	⬇️
...timelineio/console/autogen_plugin_documentation.py	64.10% <ø> (-7.94%)	⬇️
...-opentimelineio/opentimelineio/plugins/manifest.py	87.50% <ø> (+2.88%)	⬆️
tests/test_builtin_adapters.py	96.29% <ø> (+0.46%)	⬆️
tests/test_console.py	95.31% <ø> (-0.02%)	⬇️
tests/test_examples.py	90.00% <ø> (-0.48%)	⬇️
tests/test_otiod.py	96.87% <ø> (-0.05%)	⬇️
tests/test_otioz.py	97.93% <ø> (-0.03%)	⬇️
... and 4 more

... and 57 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3b673...d8ab747. Read the comment docs.

[darbyjohnston]

Replaced by #1766.