-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cibuildwheel settings to generate apple silicon wheels #1673
base: main
Are you sure you want to change the base?
Updated cibuildwheel settings to generate apple silicon wheels #1673
Conversation
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 197 197
Lines 21767 21767
Branches 4354 4354
=======================================
Hits 17379 17379
Misses 2234 2234
Partials 2154 2154
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Maybe look at https://cibuildwheel.readthedocs.io/en/stable/faq/#what-to-provide?
I hear through the branches that it's coming. See https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/#how-to-use-the-runner and https://github.com/AcademySoftwareFoundation/wg-ci/blob/main/meetings/2023-10-11.md?plain=1#L89. I'll check to see if we could have access. |
I spot checked the Apple Silicon python 3.11 wheel from the first build. I unzipped that dir into python -m pip install --find-links /tmp/otiowheels opentimelineio==0.16.0.dev1 I was then able to use Our CI currently has a I think a good refactor might be to use have one job that just runs the lint and check-manifest in a single platform (like we do with This would have some specific benefits:
The one downside I see is that cibuildwheel seems to take ~5m to build whereas |
Another consideration - universal binaries are a bit slower to import possibly - what's the tax of this? From TSC meeting: let's go with x86_64 + universal2 archs |
Fixes #1672
This is a WIP PR for enabling Apple Silicon Support.
Currently, this PR simply enables cibuildwheel for x86_64 and arm64.
TODO:
universal2
or are the optimized wheels fine?)