-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing commands #1651
Editing commands #1651
Conversation
Signed-off-by: Darby Johnston <[email protected]>
Finished edit algorithms.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
- Coverage 79.91% 79.90% -0.01%
==========================================
Files 197 197
Lines 21731 21733 +2
Branches 4339 4340 +1
==========================================
Hits 17366 17366
- Misses 2213 2215 +2
Partials 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
In case you're wondering, the DCO check fail is complaining because some commits lack the DCO line in the commit message. For example, in Darby's initial commit you can see Signed-off-by: Darby Johnston [email protected] if you rewrite the commit messages with your own signoff, and force push to your branch, it will clear up the DCO warning in the CI. |
Signed-off-by: Darby Johnston <[email protected]>
* Added transition removal. * Solved some precision issues. * Add more unit tests. Signed-off-by: Gonzalo Garramuño <[email protected]> commit 1df55fe Author: Darby Johnston <[email protected]> Date: Mon Jan 9 16:08:32 2023 -0800 Experimental editing commands Signed-off-by: Darby Johnston <[email protected]>
8fe144b
to
58a0b19
Compare
* Added transition removal. * Solved some precision issues. * Add more unit tests. Signed-off-by: Gonzalo Garramuño <[email protected]> commit 1df55fe Author: Darby Johnston <[email protected]> Date: Mon Jan 9 16:08:32 2023 -0800 Experimental editing commands Signed-off-by: Darby Johnston <[email protected]>
58a0b19
to
a34200d
Compare
Signed-off-by: Gonzalo Garramuño <[email protected]>
8b2e5a1
to
d3f6221
Compare
Signed-off-by: Gonzalo Garramuño <[email protected]>
Signed-off-by: Gonzalo Garramuño <[email protected]>
This commit is for:
Implements #1649.
Makes PR #1518 obsolete.
It implements edit commands in the otio::algo:: namespace. The commands implemented are those discussed in #711.
They are further explained more clearly in:
https://github.com/mccartnm/OpenTimelineIO/blob/openedit_design/docs/design/editorial_design.md
Summarize your change.
It implements the needed base commands for editing with otio, building on top of @darbyjohnston's PR.
@darbyjohnston 's PR #1518 was the base for it, but I debugged two subtle precision bugs in his code and moved it all to the algo:: namespace.
Implementation also modifies errorStatus.h/cpp to add NOT_A_GAP enum.
Implementation, as @darbyjohnston's, makes Composition's protected _index_of_child a now public member of the API as index_of_child and updates track.cpp accordingly.
Reference associated tests.
test_editAlgorithm.cpp is added as in @darbyjohnston, but with tests for all commands.