Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equality operators to AnyVector in Python #1575

Conversation

JeanChristopheMorinPerso
Copy link
Member

Add equality operators to AnyVector in Python. This is mostly useful for OTIO development, but it might also be useful to anyone using OTIO.

Extracted from #1490.

@codecov-commenter
Copy link

Codecov Report

Merging #1575 (7499c89) into main (6f4ed5e) will decrease coverage by 0.04%.
The diff coverage is 58.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
- Coverage   80.04%   80.00%   -0.04%     
==========================================
  Files         197      197              
  Lines       21720    21755      +35     
  Branches     4309     4316       +7     
==========================================
+ Hits        17386    17406      +20     
- Misses       2182     2197      +15     
  Partials     2152     2152              
Flag Coverage Δ
py-unittests 80.00% <58.13%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-opentimelineio/opentimelineio/core/_core_utils.py 79.69% <48.57%> (-4.82%) ⬇️
tests/test_core_utils.py 98.75% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4ed5e...7499c89. Read the comment docs.

@JeanChristopheMorinPerso
Copy link
Member Author

The implementation is working, but only for ==. I'll close and re-open when I have a better implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants