Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_children is broken with two tracks. #1652

Closed
ggarra13 opened this issue Aug 20, 2023 · 2 comments · May be fixed by #1766
Closed

find_children is broken with two tracks. #1652

ggarra13 opened this issue Aug 20, 2023 · 2 comments · May be fixed by #1766
Labels
bug A problem, flaw, or broken functionality.

Comments

@ggarra13
Copy link
Contributor

ggarra13 commented Aug 20, 2023 •
edited
Loading

Bug Report

Incorrect Functionality and General Questions

C++'s timeline->find_childrenotio::Item is broken when there are two tracks and a search range is involved.

To Reproduce

I created a PR for a test for it to show both the correct and incorrect functionality. I am also attaching the test here as .txt file.

test_find_children.cpp.txt

Expected Behavior

timeline->find_childrenotio::Item() should return all otio::Items in the range.
@ggarra13 ggarra13 added the bug A problem, flaw, or broken functionality. label Aug 20, 2023
@ggarra13 ggarra13 mentioned this issue Aug 20, 2023
Open
@darbyjohnston darbyjohnston mentioned this issue Jun 4, 2024
Closed
@darbyjohnston darbyjohnston mentioned this issue Jun 14, 2024
Open
@darbyjohnston
Copy link
Contributor

Thanks for creating this test! I created a new PR (#1766) that has a potential fix and and the test, so I'll close this one.

@ggarra13
Copy link
Contributor Author

Darby, would you be a darling and test Issue #1750? I've been wanting to attend the OTIO meetings and for one reason or another I cannot make it.
Issue #1750 is an incorrect functionality between M1 and M3 machines, which seems like a macOS compiler issue. I don't have any M1/M3 machine but I would like to know if the test works fine on an M1 machine at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Milestone
No milestone
2 participants
@ggarra13 @darbyjohnston