Add default global scale value if missing in the annotation hook #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloisebrosseau
requested review from
rogernelson,
cedrik-fuoco-adsk and
bernie-laberge
eloisebrosseau
force-pushed
the
global-scale
branch
from
15c0236 to
f01fbcd
Compare
rogernelson
reviewed
Dec 11, 2024
rogernelson
approved these changes
Dec 11, 2024
eloisebrosseau
force-pushed
the
global-scale
branch
from
957448b to
ff3ac56
Compare
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
global-scale
branch
from
ff3ac56 to
ec13993
Compare
eloisebrosseau
merged commit e015eb2
into
AcademySoftwareFoundation:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default global scale value if missing
Summarize your change.
A default global scale value is calculated based on the aspect ratio of the first source if it couldn't be obtained from the OTIO.
Describe the reason for the change.
When no
available_image_boundsis present in the OTIO, no global scale value was being calculated. This was causing an issue where the annotations couldn't be displayed in RV during a Live Review Session.Describe what you have tested and on which operating system.
Successfully test on MacOS